Repository navigation
Update great-expectations to latest (>1) #5087
Description
Expected Behavior
great-expectations version updated to latest (>1).
Current Behavior
The great_expectations.dataset module, which included classes like PandasDataset, has been deprecated in recent versions of Great Expectations and was fully removed in version 1.0. This change means that attempting to import from great_expectations.dataset will result in a ModuleNotFoundError
Steps to reproduce
Update great-expectations to latest and run sdk/python/tests/integration/offline_store/test_dqm_validation.py
Activity
Raghul-M commentedon Aug 5, 2025
@ntkathole I would like to work on this can you assign me on this?
ntkathole commentedon Aug 6, 2025
Thank you @Raghul-M
Raghul-M commentedon Jul 13, 2026
/unassign
MARCOpo1o commentedon Jul 26, 2026
Hi, I’d like to work on this issue. I reproduced the breakage with Great Expectations 1.19.1 and traced the migration beyond the removed great_expectations.dataset import
MARCOpo1o commentedon Jul 26, 2026
And also GE 1.x removed PandasDataset so the clean migration would make profiler callbacks receive a plain pd.DataFrame, which would breaks existing callbacks using ds.expect_*. Are we ok with that or do we want the API preserved?
ntkathole commentedon Jul 27, 2026
I think we are deprecating it #6594
@jyejare Keeping great_expectations in https://github.com/feast-dev/feast/blob/master/pyproject.toml#L80 intentional ?
MARCOpo1o commentedon Jul 27, 2026
jyejare commentedon Jul 27, 2026
No its not intended. We have removed it from dependencies too.
Since we now have observability built in feast API, UI we are no more dependent on GE.
angelo-lacson commentedon Sep 1, 2026
Hi, I'm Angelo Lacson, and I'd like to work on this issue.
I plan to migrate the Great Expectations integration away from the removed PandasDataset API, update the dependency constraint, and update the existing DQM validation test. Is this issue still available?
Mrun25 commentedon Oct 15, 2026
Hi! I'd love to pick this up if it's still free. I can see there was interest back in July, but no assignment or PR since, so just checking nobody is actively on it before I dive in.
I've started scoping the migration: GX 1.x reworked the core APIs (context, expectation suites, checkpoints/validation flow all moved), so this is more than a version bump - the integration points need reworking and the tests updated against the new suite model. Happy to map the full surface and open a PR with updated tests.
@ntkathole if it's available, could you assign it to me?
CyberRik commentedon Nov 4, 2026
I'd like to pick this up - could you assign me?
Before opening a PR I'd like to confirm the intended direction, since it changes the shape of the fix. The GE integration is still in the code:
sdk/python/feast/dqm/profilers/ge_profiler.pyis built ongreat_expectations.dataset.PandasDatasetandge.validate(), both removed in Great Expectations 1.0, andpyproject.tomlstill carriesge = ["great_expectations>=0.15.41,<1"]. #6594 removed GE from the docs but left the code and the optional extra in place.Given the earlier note that Feast is no longer dependent on GE now that observability is built into the API/UI, which path do you prefer?
ge_profiler.py, thegeextra, and thetest_dqm_validation.pytest — matching the deprecation direction.PandasDataset, so user-defined profilers that callds.expect_*()would instead receive a plainpd.DataFrame(or aValidator), which changes the public@ge_profilerAPI.Happy to do either once you confirm the preferred path.