Skip to content

Remove unused (and out-of-place) FeatureStore.version function #4747

Closed

Description

@dandawg

The FeatureStore class has a version function which returns the Python SDK version. This gives the illusion that it is needed in the class, but it is never actually used. When I first saw it, I was confused why the class would have a version (which is why I dug into the source code). I propose simplifying the FeatureStore class by dropping the FeatureStore.version function.

The benefit will be making the code easier to understand, with less opportunity for error.

Expected Behavior

I expect the FeatureStore class not to have a version function, as it is not used and not needed.

Even if it were needed, the better way to get the version would be either directly through the function it calls (version.get_version -- also part of the SDK), or by calling feast.__version__.

Current Behavior

The FeatureStore class defines a version function that is never used.

def version(self) -> str:

Steps to reproduce

Specifications

  • Version: 0.41.3
  • Platform: NA
  • Subsystem: NA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions