Skip to content

Use ASOF JOIN in Snowflake Source #4732

Closed

Description

@nanohanno

Is your feature request related to a problem? Please describe.

Requesting historical features from Snowflake uses multiple intermediate results to do the point-in-time correct join. Recently, a new Snowflake feature was released which does exactly what we would expect from the join: ASOF JOIN (https://www.snowflake.com/en/blog/time-series-analytics-asof-join-generally-available/). The reported improvements in efficiency are very substantial.

Describe the solution you'd like

Could we use the ASOF JOIN in https://github.com/feast-dev/feast/blame/d1d80c0d208e25b92047fe5f162c67c00c69bb43/sdk/python/feast/infra/offline_stores/snowflake.py#L717 to improve efficiency of the query? From a superficial view it seems to be possible, only the ttl feature might be difficult with ASOF JOINs.

Describe alternatives you've considered

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions