Repository navigation
Allow create_project to rerun safely #453
Description
Is your feature request related to a problem? Please describe.
Having the create_project method on the Feast Client fail when a project exists is important, but its also a pain in development. It means one part of the code in a notebook should be skipped every time.
Describe the solution you'd like
It would be convenient to be able to run create_project multiple times without having the second call throw an exception.
Something like
client.create_project("my-project", skip_if_exists=True)
Describe alternatives you've considered
Alternatively we can use set_project and only create the project lazily when its needed.
Activity
woop commentedon Feb 2, 2020
On second thought, it might be better to use the alternative suggested above. So we could encourage users to almost always just use
set_project. When they apply resources or run commands it will create the project if it doesnt exist. If it does exist it will try to use it.Joostrothweiler commentedon Mar 8, 2020
@woop I would be happy to pick this up as a first issue.
I could change the signature to:
def set_project(self, project: str, create_if_not_exists : bool = True):Would you say the preferred default value of
create_if_not_existsisTrueorFalsein this case?woop commentedon Mar 10, 2020
It would be awesome if you could pick this up @Joostrothweiler!
My thoughts on this topic have evolved a little bit. Here is what I am thinking
createa project norseta project.defaultfor this project name, following the lead of Kubernetes having adefaultnamespace.For the purposes of this specific issue, I think the scope is a little bit more limited.
defaultHope that makes sense :)