You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are quite some vulnerabilities in feast when I build docker image of k8s materialization engine.
Seems to be all go related. Would appreciate alteast removing critical and high one's ASAP. Thanks
@EXPEbdodla Let me use this opportunity to involve you here. So far we have been steering clear of the go codebase as (at least my) assumption is that the best path forward would be to upstream the changes from your fork instead of diverging in any way. I realize we have never really discussed that though 😄 Is upstreaming also what you're working towards?
@EXPEbdodla which version did you check for this list of Vulns? in the latest version (0.40.1) , I didn't see this package github.com/gogo/protobuf v1.2.1
We are using google.golang.org/protobuf v1.34.2 version.
@tokoko We can do that. But we have a backlog item for using endpoint from feature_store.yaml for transformation server calls. Once we fix that, we can do that. And we also use Datadog for our monitoring. It's added in code. Easy to resolve.
sorry, It seems I asked a wrong person about the question.... .my bad. @EXPEbdodla. Apologize about this. @brijesh-vora-sp which Feast version are you using for build the materialization engine?
@shuchu I believe it was until this commit c42d9fd if I am not mistaken. This vulnerabilities are created using crowdstrike. Not sure where github.com/gogo/protobuf one is coming from.
Activity
tokoko commentedon Sep 9, 2024
@EXPEbdodla Let me use this opportunity to involve you here. So far we have been steering clear of the go codebase as (at least my) assumption is that the best path forward would be to upstream the changes from your fork instead of diverging in any way. I realize we have never really discussed that though 😄 Is upstreaming also what you're working towards?
shuchu commentedon Sep 21, 2024
@EXPEbdodla which version did you check for this list of Vulns? in the latest version (0.40.1) , I didn't see this package
github.com/gogo/protobuf v1.2.1EXPEbdodla commentedon Sep 21, 2024
We are using
google.golang.org/protobuf v1.34.2version.@tokoko We can do that. But we have a backlog item for using endpoint from feature_store.yaml for transformation server calls. Once we fix that, we can do that. And we also use Datadog for our monitoring. It's added in code. Easy to resolve.
shuchu commentedon Sep 24, 2024
sorry, It seems I asked a wrong person about the question.... .my bad. @EXPEbdodla. Apologize about this.
@brijesh-vora-sp which Feast version are you using for build the materialization engine?
brijesh-vora-sp commentedon Sep 24, 2024
@shuchu I believe it was until this commit c42d9fd if I am not mistaken. This vulnerabilities are created using crowdstrike. Not sure where github.com/gogo/protobuf one is coming from.
brijesh-vora-sp commentedon Sep 24, 2024
Ok, so I cloned the repo and created docker image on master (e675cbd) 09/23. Checked vulnerabilities again. Here are the updated ones:
<style> </style>brijesh-vora-sp commentedon Sep 24, 2024
Most of these are coming from python3.11 image used. Can you update that to latest non-vulnerable image?
Below image is from docker desktop. So after building the image you can check in vulnerabilities section if are any.
shuchu commentedon Sep 25, 2024
Thank you for all the details, @brijesh-vora-sp , let me work on this.