You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add feature transformation support to FeatureView #4277
@franciscojavierarceo Just to make sure we're on the same page, do you think we should have a different BatchFeatureView class for this just like odfvs and stream feature views, right?
Also, I think we should probably implement it w/o scheduled materialization at first, because it's not really obvious to me which feast service could do the scheduling for this (flight server seems most logical or maybe we need to add another service altogether).
And maybe in the decorator we have a way to map to when the computation is happening?
My view is that we need to provide clarity about when transformations happen (on demand, during a write, or in a stream--i.e., before a write) and I'm not sure the current way does this as obviously. Maybe it does.
Actually this is more general and does not handle the batch transformation use case so keeping this open. The ODFV writes do help for a subset of these items.
Activity
tokoko commentedon Jul 8, 2024
@franciscojavierarceo Just to make sure we're on the same page, do you think we should have a different
BatchFeatureViewclass for this just like odfvs and stream feature views, right?Also, I think we should probably implement it w/o scheduled materialization at first, because it's not really obvious to me which feast service could do the scheduling for this (flight server seems most logical or maybe we need to add another service altogether).
franciscojavierarceo commentedon Jul 8, 2024
I am starting to think having the decorator of feature view type is weird.
Instead we could just do something like:
And maybe in the decorator we have a way to map to when the computation is happening?
My view is that we need to provide clarity about when transformations happen (on demand, during a write, or in a stream--i.e., before a write) and I'm not sure the current way does this as obviously. Maybe it does.
franciscojavierarceo commentedon Aug 12, 2024
This will be solved #4376
franciscojavierarceo commentedon Aug 12, 2024
Actually this is more general and does not handle the batch transformation use case so keeping this open. The ODFV writes do help for a subset of these items.
Vishnu-Rangiah commentedon Oct 21, 2024
Chaining transformation into a dag which can be reused across FVs would be nice to have. This functionality would reduce code duplication across the feature repo. Here is an example adapted from tecton's transformation API: https://docs.tecton.ai/docs/defining-features/feature-views/transformations#a-feature-view-that-calls-a-pyspark-transformation-passing-two-pyspark-transformation-outputs
franciscojavierarceo commentedon Mar 4, 2025
Will be solved by #4584