Repository navigation
SqlRegistry _apply_object doesn't take into account match with project_id when updating row #4027
Description
SqlRegistry _apply_object doesn't take into account match with project_id when updating row.
https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/registry/sql.py#L736
Wrong (as is):
.where(getattr(table.c, id_field_name) == name)
Correct:
.where(getattr(table.c, id_field_name) == name, table.c.project_id == project)
Reacted by Tornike Gurgenidze
Activity
[-]SqlRegistry _apply_object doesn't take into account match with project_id on update[/-][+]SqlRegistry _apply_object doesn't take into account match with project_id when updating row[/+]tokoko commentedon Mar 25, 2024
@Nmroth42 thanks, would you like to open a PR for this?
Nmroth42 commentedon Mar 26, 2024
#4042