Skip to content

How load defualt value when environ variable is not set #3669

Closed

Description

@GyuminJack

Expected Behavior

${REDIS_CONNECTION_STRING:"0.0.0.0:6379"}
-> when "REDIS_CONNECTION_STRING" is not set, i expect return value is "0.0.0.0:6379"
but not properly working

Current Behavior

only returns "${REDIS_CONNECTION_STRING:"0.0.0.0:6379"}"

  • maybe that function developed via (0433459)

  • could you tell me the code how can get default value with parsing?

Steps to reproduce

type that string is feature_store.yaml

Specifications

  • Version: python3.9, feast 0.31.1
  • Platform:
  • Subsystem:

Possible Solution

Activity

  1. tmihalac commented on Apr 15, 2024

    @tmihalac
    Contributor

    Current Behavior

    only returns "${REDIS_CONNECTION_STRING:"0.0.0.0:6379"}"

    Hello @GyuminJack , can you please clarify what exactly did you mean?
    What are the steps to reproduce the returned string you mentioned, I want to write a test that reproduces the issue to resolve it.

  2. added a commit that references this issue on Apr 23, 2024
    21d1039
  3. tmihalac commented on Apr 23, 2024

    @tmihalac
    Contributor

    The current code does not support default value in the Redis connection string, I am going to fix the documentation

  4. added a commit that references this issue on Apr 25, 2024
    95acfb4
  5. added a commit that references this issue on Apr 25, 2024
    0310a2c
  6. added a commit that references this issue on Apr 25, 2024
    8b5698f
  7. added a commit that references this issue on Apr 25, 2024
    d089b0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions