SQL Registry does not populate cache correctly

Expected Behavior

Using SQL registry, should be able to retrieve online features for an existing feature view using the Python SDK.

Current Behavior

FeatureStore.get_online_features() currently returns a FeatureviewNotFoundException, despite the feature view existing as evidenced by the output of FeatureStore.list_feature_views().

Steps to reproduce

Configure feature store using an SQL registry
Create a feature view
Materialize data to online store for the feature view
Attempt to retrieve the online features using FeatureStore.get_online_features()

Specifications

Version: 0.27.1
Platform: macOS Monterey 12.4
Python 3.9.16
SQL Registry, using postgres on an AWS AuroraDB instance

Possible Solution

This error seems to be specific to the SQL registry, as I have followed the exact same steps using a File registry and there is no issue. I can also circumvent the error by disabling the cache for the SQL registry, so it seems localized to the SQL registry cache itself. The feature views are successfully retrieved, but are rejected by this line because their spec does not have a project.

It appears that normally, the project is attached to the proto spec right before committing registry changes (like so, but the SQL registry does not do this and instead relies on each class's to_proto() output, which does not contain the project. This issue appears to extend to other types of objects as well (entities, etc.)

Confirmed issue still exists in 0.28.0

Confirmed issue still exists in 0.29.0

We have the same issue and my debugging leads to the same solution as mentioned above.

Incase it's helpful for anyone, I've been using the following fix in my project for a couple of versions now (works in at least 0.27.1 through 0.29.0).

Replace this line with the following:

                    protos = []
                    for obj in objs:
                        proto = obj.to_proto()
                        if hasattr(proto, "spec"):
                            proto.spec.project = project
                        protos.append(proto)

                    registry_proto_field.extend(protos)

I can't guarantee it's totally correct, but I haven't had any problems with it thus far.

Thanks for the fix. Looking forward for the new release. Is there any timeline for the new release?

Navigation Menu

Repository navigation

SQL Registry does not populate cache correctly #3430

Expected Behavior

Current Behavior

Steps to reproduce

Specifications

Possible Solution

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

SQL Registry does not populate cache correctly #3430

Description

Expected Behavior

Current Behavior

Steps to reproduce

Specifications

Possible Solution

Activity

cbarcroft commented on Jan 5, 2023

cbarcroft commented on Feb 1, 2023

EXPEbdodla commented on Feb 1, 2023

cbarcroft commented on Feb 1, 2023

EXPEbdodla commented on Feb 28, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions