Skip to content

Test loading S3 parquet folder in dataset format #3235

Closed

Description

@mzwiessele

Test that a parquet dataset saved in dataset format can be loaded and accessed using get_historical_features.

Steps:

  • upload a parquet dataset to the test s3 folder
  • point a source to the parquet dataset s3 folder (not the file)
  • load the source features using get_historical_features

Ideally, there'd be a test for this running, but you'd be blocked on making a file within the Feast integration tests S3 bucket. Mind making an issue for that separately? @mzwiessele

Originally posted by @adchia in #3217 (comment)

Activity

  1. changed the title [-]Ideally, there'd be a test for this running, but you'd be blocked on making a file within the Feast integration tests S3 bucket. Mind making an issue for that separately? @mzwiessele[/-] [+]Test loading S3 parquet folder in dataset format[/+] on Sep 20, 2022
  2. felixwang9817 commented on Sep 24, 2022

    @felixwang9817
    Collaborator

    I think there are probably two ways to do this:

    • there is an S3FileDataSourceCreator in sdk/python/tests/integration/universal/feature_repos/universal/data_sources/file.py, which uses minio - it hasn't been used in a while, but it could be updated and used
    • instead of using minio, we could also just create a dataset and upload data directly to an S3 bucket - we could just use the feast-integration-tests S3 bucket, which is used in universal/data_sources/redshift.py

    @mzwiessele if you want to take this on, I'd be happy to help you and review any PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions