Skip to content

Wrong condition in to_snowflake method of snowflake provider #3045

Closed

Description

@floOnfido

Expected Behavior

to_snowflake should ignore on_demand_feature_views if on_demand_feature_views is an empty list

Current Behavior

to_snowflake runs on_demand_feature_views code because on_demand_feature_views is set to [] here

Steps to reproduce

Specifications

  • Version: 0.23.0
  • Platform: feast SDK
  • Subsystem:

Possible Solution

if self.on_demand_feature_views is not None: => if self.on_demand_feature_views is not []:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions