Skip to content

Snowflake source warehouse field is unused #2981

Closed

Description

@sfc-gh-madkins

Expected Behavior

Id expect if I defined a warehouse source that warehouse would be used for inference functions attached to the source.

Current Behavior

Source uses offline store credentials

Steps to reproduce

Specifications

  • Version:
  • Platform:
  • Subsystem:

Possible Solution

I think we remove warehouse from snowflake source as source and offline store are currently intertwined

you can either define a query or a database.schema.table path

Activity

  1. achals commented on Jul 28, 2022

    @achals
    Member

    Yeah this is strange behaviour. If we keep the warehouse field in the source it should take precedence, otherwise we can remove the field altogether. I'm fine either way.

  2. sfc-gh-madkins commented on Jul 28, 2022

    @sfc-gh-madkins
    CollaboratorAuthor

    Until Feast supports a framework where any source can be fed into any offlinestore, it makes sense to remove it. If we wanted this to take precedence, in theory warehouse wouldnt be enough, we would need to add another entire set of snowflake credentials. (makes no sense)

  3. stale commented on Dec 16, 2022

    @stale

    This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

  4. sfc-gh-madkins commented on Dec 16, 2022

    @sfc-gh-madkins
    CollaboratorAuthor

    bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions