Skip to content

FeatureStore._plan should be a public method #2895

Closed

Description

@achals

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

https://github.com/feast-dev/feast/blob/master/sdk/python/feast/feature_store.py#L639

Ideally, all FeatureStore methods that back a CLI operation should have a public facing programatic API. In this case, feast plan users FeatureStore._plan -> which signifies that it should be treated as a private method.

Describe the solution you'd like
The change would be as simple as refactoring it to FeatureStore.plan.

Activity

  1. achals commented on Jun 30, 2022

    @achals
    MemberAuthor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions