Skip to content

Missing key error in snowflake_python_type_to_feast_value_type in type_map for numpy datetime64 with timezone #2793

Closed

Description

@tlam-lyra

Expected Behavior

Feast should be able to handle different source column data types when updating feature views with inferred features. Specifically all possible datetime64 python data types with specific timezones should be handled.

Current Behavior

Snowflake python type datetime64[ns, america/los_angeles] does not have a corresponding feast ValueType. There's a ValueType for datetime64[ns] but not a numpy datetime64 with a specific timezone

File "/opt/homebrew/anaconda3/envs/feast-python37/lib/python3.7/site-packages/feast/type_map.py", line 536, in snowflake_python_type_to_feast_value_type
    return type_map[snowflake_python_type_as_str.lower()]
KeyError: 'datetime64[ns, america/los_angeles]'

Steps to reproduce

Specifications

  • Version: 0.21.3
  • Platform: Mac OSX Monterey 12.4
  • Subsystem:

Possible Solution

Activity

  1. kevjumba commented on Jun 15, 2022

    @kevjumba
    Collaborator

    Hi @tlam-lyra could you add a pr for a fix to support these types?

  2. sfc-gh-madkins commented on Aug 15, 2022

    @sfc-gh-madkins
    Collaborator

    @tlam-lyra @kevjumba taking a look.

    @tlam-lyra can you tell me what the snowflake datatype is? TIMESTAMP_TZ?

  3. sfc-gh-madkins commented on Aug 15, 2022

    @sfc-gh-madkins
    Collaborator

    See #3083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions