Repository navigation
basicConfig is called at the module level #2664
Description
Expected Behavior
import feast
logging.basicConfig(level=level, format=FORMAT)
logging.error("msg")
should print logging message according to FORMAT
Current Behavior
It uses the format defined in feast at the module level.
Steps to reproduce
Same as in "Expected Behavior"
Specifications
- Version: 0.18.1
- Platform: Linux
- Subsystem: -
Possible Solution
I see that basicConfig is called here:
Line 84 in c9eda79
feast/sdk/python/feast/__init__.py
Line 30 in 0ca6297
If there are any other entry points that need to set up logging, they should call the function, but the call in __init__.py must be removed.
Activity
achals commentedon May 12, 2022
I think you're right @elshize - good catch. Would you be willing to submit a PR for this? :)
achals commentedon May 12, 2022
Actually I'm going to quickly fix this so that we can include the fix in the release we're planning on cutting tomorrow.
elshize commentedon May 12, 2022
@achals Thanks. Sorry I didn't reply sooner, it was nighttime here :)