Data source conversion from protobuf doesn't use type information #2409

Activity

1. woop

   added

   kind/bug

   priority/p2

   on Mar 15, 2022
2. github-actions

   assigned

   achals

   on Mar 15, 2022
3. felixwang9817 commented on Mar 15, 2022

   

   felixwang9817

   on Mar 15, 2022

   Last edited by felixwang9817

   Collaborator

   More actions

   @woop what do you mean by doesn't exist? I see data_source_class_type in DataSource.proto:

   // This is an internal field that is represents the python class for the data source object a proto object represents.
   // This should be set by feast, and not by users.
   string data_source_class_type = 17;
   

   and I also see it being set correctly in the code:

   batch_source_proto = self.batch_source.to_proto()
   batch_source_proto.data_source_class_type = f"{self.batch_source.__class__.__module__}.{self.batch_source.__class__.__name__}"
   
4. adchia commented on Mar 15, 2022

   

   adchia

   on Mar 15, 2022

   Collaborator

   More actions

   Yep. I think there is some bug that might have been introduced when we started storing data sources separately since the feature view class adds that, but i don't think we add this class_type with applying data sources to the registry.
5. feast-ci-bot

   closed this as completedin #2424on Mar 22, 2022