Skip to content

Snowflake login support private key or web browser authentication #2292

Closed

Description

@realLyans

The current snowflake support seems only allow password authentication but we are using Azure AD login without password for the account.
Can we add functionality to allow different mechanism of authentication?

Activity

  1. felixwang9817 commented on Feb 8, 2022

    @felixwang9817
    Collaborator

    @realLyans thanks for this feature request! cc @sfc-gh-madkins who's been working on Snowflake - do you think this could be supported easily?

  2. realLyans commented on Feb 11, 2022

    @realLyans
    Author

    From what I can see backend is not very hard - just need to change https://github.com/feast-dev/feast/blob/f2bc4119b44fd35ea6739118273cfa48aa243cbe/sdk/python/feast/infra/utils/snowflake_utils.py to add different method of authentication; main question is design of front end which I am not very familiar with.

  3. adchia commented on Feb 14, 2022

    @adchia
    Collaborator

    by frontend do you mean what the ideal API is in defining the SnowflakeSource? I think it'd probably be a new field and then we enforce with some validation check in the constructor that the user has only one form of authentication specified.

  4. realLyans commented on Feb 16, 2022

    @realLyans
    Author

    @adchia meaning the CLI interface that sets up the repo which doesn't really allow configuration there and I am also not too sure how I should enter a private key if it being a long binary typed variable. I don't think SnowflakeSource need a change (I might be wrong).

  5. sfc-gh-madkins commented on Feb 19, 2022

    @sfc-gh-madkins
    Collaborator

    @felixwang9817 @adchia @realLyans -- the snowflake integration for feast relies on the snowflake-connector-python ... any authentication method available for that package is available to feast users. The current design is for your project .yaml file to override any values set in a config file that by defaults points at where you config lives if you download the snowflake CLI tool ... if you want to define your own config file ... simple provide the path in the project .yaml file

    Where the enhancement needs to happen is that the snowflake connection method should accept kwargs ... which it currently doesnt

  6. sfc-gh-madkins commented on Mar 3, 2022

    @sfc-gh-madkins
    Collaborator

    This PR here should allow of forms of authentication available to the snowflake python connector to work for a feast project: #2356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions