You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Run feast cli command without cd into feature repo directory #1507
Is your feature request related to a problem? Please describe.
Is it possible to run a feast command i.e. feast apply, without cd into the feature repo directory?
Describe the solution you'd like
feast -p feature_repo apply
feast -p feature_repo materialize-incremental $CURRENT_TIME
Upon further consideration, it looks like Terraform does support this via the --chdir flag. This does seem like useful functionality to have, so no opposition to adding this.
However, I think we should generally line up our declarative APIs with theirs, so my vote is to ship their specific API (--chdir and the same behavior.) @tedhtchang would it be possible to amend your PR?
@jparthasarthy technically Terraform's flag is -chdir, but I prefer to follow a more standard approach of one hyphen for short command and two hyphens for long commands. So I agree it should be --chdir, but would be nice to have a shorthand too, maybe -c?
Activity
woop commentedon Apr 27, 2021
I think this change requires a bit of discussion. We used to have this support and we removed it to be more closely aligned with Terraform.
@tsotnet @jparthasarthy do you have thoughts on this?
jparthasarthy commentedon Apr 27, 2021
Upon further consideration, it looks like Terraform does support this via the
--chdirflag. This does seem like useful functionality to have, so no opposition to adding this.However, I think we should generally line up our declarative APIs with theirs, so my vote is to ship their specific API (--chdir and the same behavior.) @tedhtchang would it be possible to amend your PR?
tsotnet commentedon Apr 27, 2021
@jparthasarthy technically Terraform's flag is
-chdir, but I prefer to follow a more standard approach of one hyphen for short command and two hyphens for long commands. So I agree it should be--chdir, but would be nice to have a shorthand too, maybe-c?jparthasarthy commentedon Apr 27, 2021
SGTM @tsotnet