Skip to content

Commit f8579a9

Browse files
committed
revert removing ge
Signed-off-by: Danny Chiao <[email protected]>
1 parent 6cbdeda commit f8579a9

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

‎sdk/python/feast/feature_store.py‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
from feast.data_source import DataSource
4343
from feast.diff.infra_diff import InfraDiff, diff_infra_protos
4444
from feast.diff.registry_diff import RegistryDiff, apply_diff_to_registry, diff_between
45-
from feast.dqm.profilers.ge_profiler import GEProfiler
4645
from feast.entity import Entity
4746
from feast.errors import (
4847
EntityNotFoundException,
@@ -881,7 +880,6 @@ def create_saved_dataset(
881880
storage: SavedDatasetStorage,
882881
tags: Optional[Dict[str, str]] = None,
883882
feature_service: Optional[FeatureService] = None,
884-
profiler: Optional[GEProfiler] = None,
885883
) -> SavedDataset:
886884
"""
887885
Execute provided retrieval job and persist its outcome in given storage.

‎sdk/python/setup.py‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
"fastavro>=1.1.0",
4747
"google-api-core>=1.23.0",
4848
"googleapis-common-protos==1.52.*",
49-
"great_expectations>=0.14.0,<0.15.0",
5049
"grpcio>=1.34.0",
5150
"grpcio-reflection>=1.34.0",
5251
"Jinja2>=2.0.0",
@@ -97,6 +96,10 @@
9796
"pyspark>=3.0.0",
9897
]
9998

99+
GE_REQUIRED = [
100+
"great_expectations>=0.14.0,<0.15.0"
101+
]
102+
100103
CI_REQUIRED = (
101104
[
102105
"cryptography==3.3.2",
@@ -143,6 +146,7 @@
143146
+ AWS_REQUIRED
144147
+ SNOWFLAKE_REQUIRED
145148
+ SPARK_REQUIRED
149+
+ GE_REQUIRED
146150
)
147151

148152
DEV_REQUIRED = ["mypy-protobuf>=3.1.0", "grpcio-testing==1.*"] + CI_REQUIRED
@@ -246,6 +250,7 @@ def run(self):
246250
"redis": REDIS_REQUIRED,
247251
"snowflake": SNOWFLAKE_REQUIRED,
248252
"spark": SPARK_REQUIRED,
253+
"ge": GE_REQUIRED,
249254
},
250255
include_package_data=True,
251256
license="Apache",

0 commit comments

Comments
 (0)