Skip to content

Commit dc79121

Browse files
committed
nullability fixes
Signed-off-by: Achal Shah <[email protected]>
1 parent 525e230 commit dc79121

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

‎sdk/python/feast/infra/passthrough_provider.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def __init__(self, config: RepoConfig):
4444

4545
@property
4646
def online_store(self):
47-
if not self._online_store:
47+
if not self._online_store and self.repo_config.online_store:
4848
self._online_store = get_online_store_from_config(
4949
self.repo_config.online_store
5050
)

‎sdk/python/tests/integration/feature_repos/integration_test_repo_config.py‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class IntegrationTestRepoConfig:
1919
"""
2020

2121
provider: str = "local"
22-
online_store: Union[str, Dict] = "sqlite"
22+
online_store: Optional[Union[str, Dict]] = "sqlite"
2323

2424
offline_store_creator: Type[DataSourceCreator] = FileDataSourceCreator
2525
online_store_creator: Optional[Type[OnlineStoreCreator]] = None
@@ -38,8 +38,10 @@ def __repr__(self) -> str:
3838
online_store_type = self.online_store.get("redis_type", "redis")
3939
else:
4040
online_store_type = self.online_store["type"]
41-
else:
41+
elif self.online_store:
4242
online_store_type = self.online_store.__name__
43+
else:
44+
online_store_type = "none"
4345
else:
4446
online_store_type = self.online_store_creator.__name__
4547

0 commit comments

Comments
 (0)