Skip to content

Commit d6cc1dc

Browse files
Srihari1192ntkathole
authored andcommitted
fix: Use upstream kubectl image as feast-operator CronJob default
Signed-off-by: Srihari <[email protected]>
1 parent 106bfb5 commit d6cc1dc

8 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎infra/feast-operator/Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ OPERATOR_SDK_VERSION ?= v1.41.0
5454
# the dev image generated using command `make build-feature-server-dev-docker`
5555
IMG ?= $(IMAGE_TAG_BASE):$(VERSION)
5656
FS_IMG ?= quay.io/feastdev/feature-server:$(VERSION)
57-
CJ_IMG ?= quay.io/openshift/origin-cli:4.17
57+
CJ_IMG ?= registry.k8s.io/kubectl:v1.35.9
5858
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
5959
ENVTEST_K8S_VERSION = 1.31.0
6060

‎infra/feast-operator/bundle/manifests/feast-operator.clusterserviceversion.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ spec:
472472
- name: RELATED_IMAGE_FEATURE_SERVER
473473
value: quay.io/feastdev/feature-server:0.66.0
474474
- name: RELATED_IMAGE_CRON_JOB
475-
value: quay.io/openshift/origin-cli:4.17
475+
value: registry.k8s.io/kubectl:v1.35.9
476476
- name: GOMEMLIMIT
477477
value: 230MiB
478478
- name: OIDC_ISSUER_URL
@@ -568,6 +568,6 @@ spec:
568568
relatedImages:
569569
- image: quay.io/feastdev/feature-server:0.66.0
570570
name: feature-server
571-
- image: quay.io/openshift/origin-cli:4.17
571+
- image: registry.k8s.io/kubectl:v1.35.9
572572
name: cron-job
573573
version: 0.66.0

‎infra/feast-operator/config/default/related_image_fs_patch.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ spec:
1111
- name: RELATED_IMAGE_FEATURE_SERVER
1212
value: quay.io/feastdev/feature-server:0.66.0
1313
- name: RELATED_IMAGE_CRON_JOB
14-
value: quay.io/openshift/origin-cli:4.17
14+
value: registry.k8s.io/kubectl:v1.35.9

‎infra/feast-operator/config/manager/manager.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ spec:
7878
- name: RELATED_IMAGE_FEATURE_SERVER
7979
value: feast:latest
8080
- name: RELATED_IMAGE_CRON_JOB
81-
value: origin-cli:latest
81+
value: registry.k8s.io/kubectl:v1.35.9
8282
# Injected from params.env via kustomize replacements (ODH/RHOAI overlays).
8383
# Open Data Hub operator sets this from GatewayConfig when the cluster uses external OIDC.
8484
- name: OIDC_ISSUER_URL
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
RELATED_IMAGE_FEAST_OPERATOR=quay.io/feastdev/feast-operator:0.66.0
22
RELATED_IMAGE_FEATURE_SERVER=quay.io/feastdev/feature-server:0.66.0
3-
RELATED_IMAGE_CRON_JOB=quay.io/openshift/origin-cli:4.17
3+
RELATED_IMAGE_CRON_JOB=registry.k8s.io/kubectl:v1.35.9
44
# Set at deploy time by the Open Data Hub operator from GatewayConfig (external OIDC).
55
OIDC_ISSUER_URL=

‎infra/feast-operator/dist/install.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24609,7 +24609,7 @@ spec:
2460924609
- name: RELATED_IMAGE_FEATURE_SERVER
2461024610
value: quay.io/feastdev/feature-server:0.66.0
2461124611
- name: RELATED_IMAGE_CRON_JOB
24612-
value: quay.io/openshift/origin-cli:4.17
24612+
value: registry.k8s.io/kubectl:v1.35.9
2461324613
- name: GOMEMLIMIT
2461424614
value: 230MiB
2461524615
- name: OIDC_ISSUER_URL

‎infra/feast-operator/internal/controller/services/cronjob.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ func (feast *FeastServices) getCronJobPodSpec() corev1.PodSpec {
155155
},
156156
}
157157
// On vanilla Kubernetes (e.g. Kind) we must set an explicit non-root UID
158-
// because the default CronJob image (origin-cli) runs as root.
158+
// because the default CronJob image (registry.k8s.io/kubectl) runs as root.
159159
// On OpenShift the restricted-v2 SCC auto-assigns a UID from the
160160
// namespace's allowed range, so we must NOT set RunAsUser.
161161
if !IsOpenShift() {

‎infra/feast-operator/internal/controller/services/services_types.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ const (
186186

187187
var (
188188
DefaultImage = "quay.io/feastdev/feature-server:" + feastversion.FeastVersion
189-
DefaultCronJobImage = "quay.io/openshift/origin-cli:4.17"
189+
DefaultCronJobImage = "registry.k8s.io/kubectl:v1.35.9"
190190
DefaultPVCAccessModes = []corev1.PersistentVolumeAccessMode{corev1.ReadWriteOnce}
191191
NameLabelKey = feastdevv1.GroupVersion.Group + "/name"
192192
ServiceTypeLabelKey = feastdevv1.GroupVersion.Group + "/service-type"

0 commit comments

Comments
 (0)