Repository navigation
Commit b4d932a
committed
fix: Address review feedback on vector length validation
Three findings from review of #6909.
Tolerate genuine nulls on the DataFrame path (@ntkathole). lengths.isna() was
true both for values that were not sequences and for rows that were genuinely
null, so a null vector was reported as "not a sequence". Nulls are now skipped,
which also makes this path consistent with the Arrow path, which already
tolerated null rows.
Report the first offending row across both failure modes (Copilot). Checking
the not-a-sequence mask fully before the length mask meant a non-sequence in a
later row was reported ahead of a wrong length in an earlier one. The masks are
now unioned and the first offending position selected before choosing the
message, which restores the row ordering the original iterrows loop had. Value
lookup is positional so a DataFrame with a duplicate index reports a scalar
type rather than a Series.
Validate the on-demand branch too (Copilot). _convert_arrow_to_proto dispatches
to _convert_arrow_odfv_to_proto or _convert_arrow_fv_to_proto, and the check sat
in the regular branch only, so a stored ODFV declaring vector_length had its
transformed output unchecked. The call moved up into the dispatcher, ahead of
the branch, so both paths are covered.
Each finding has a test that fails against the previous commit and passes here.
Signed-off-by: hao-xu5 <[email protected]>1 parent 5e66d6e commit b4d932a
3 files changed
Lines changed: 113 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3640 | 3640 | | |
3641 | 3641 | | |
3642 | 3642 | | |
3643 | | - | |
3644 | | - | |
3645 | | - | |
| 3643 | + | |
| 3644 | + | |
| 3645 | + | |
| 3646 | + | |
| 3647 | + | |
| 3648 | + | |
| 3649 | + | |
| 3650 | + | |
| 3651 | + | |
| 3652 | + | |
3646 | 3653 | | |
3647 | | - | |
3648 | | - | |
3649 | | - | |
3650 | | - | |
3651 | | - | |
3652 | | - | |
| 3654 | + | |
| 3655 | + | |
| 3656 | + | |
| 3657 | + | |
| 3658 | + | |
3653 | 3659 | | |
3654 | | - | |
3655 | | - | |
3656 | | - | |
| 3660 | + | |
| 3661 | + | |
| 3662 | + | |
| 3663 | + | |
| 3664 | + | |
| 3665 | + | |
| 3666 | + | |
3657 | 3667 | | |
3658 | | - | |
3659 | | - | |
| 3668 | + | |
| 3669 | + | |
3660 | 3670 | | |
3661 | 3671 | | |
| 3672 | + | |
| 3673 | + | |
| 3674 | + | |
| 3675 | + | |
| 3676 | + | |
| 3677 | + | |
3662 | 3678 | | |
3663 | 3679 | | |
3664 | 3680 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
502 | 502 | | |
503 | 503 | | |
504 | 504 | | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
505 | 508 | | |
506 | 509 | | |
507 | 510 | | |
| |||
525 | 528 | | |
526 | 529 | | |
527 | 530 | | |
528 | | - | |
529 | | - | |
530 | 531 | | |
531 | 532 | | |
532 | 533 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
0 commit comments