Repository navigation
Commit b1f2168
fix: Use date-only bounds for partition filters built from string timestamps (#7116)
get_timestamp_filter_sql formats datetime bounds as dates for the date_partition_column predicate, but returned string bounds unchanged. Athena's pull_all_from_table_or_query passes strings such as '2026-02-01 01:00:00.000', so the partition predicate became dt >= '2026-02-01 01:00:00.000'. Against a 'YYYY-MM-DD' partition value that compares false, which drops the whole first day. Truncate string bounds to their date part.
Signed-off-by: sohailshk <[email protected]>
Co-authored-by: Shuchu Han <[email protected]>1 parent 8fdcee7 commit b1f2168
2 files changed
Lines changed: 56 additions & 1 deletion
File tree
- sdk/python
- feast/infra/offline_stores
- tests/unit/infra/offline_stores/contrib/athena_offline_store
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
412 | 412 | | |
413 | 413 | | |
414 | 414 | | |
415 | | - | |
| 415 | + | |
| 416 | + | |
416 | 417 | | |
417 | 418 | | |
418 | 419 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
0 commit comments