Skip to content

Commit 9ac7f4e

Browse files
peruukkiperuukki
authored
fix: Remove unnecessary peer dependencies from Feast UI (#4577)
1 parent 3198371 commit 9ac7f4e

3 files changed

Lines changed: 19 additions & 16 deletions

File tree

‎docs/reference/alpha-web-ui.md‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,14 @@ Start with bootstrapping a React app with `create-react-app`
4545
npx create-react-app your-feast-ui
4646
```
4747

48-
Then, in your app folder, install Feast UI and its peer dependencies. Assuming you use yarn
48+
Then, in your app folder, install Feast UI and optionally its peer dependencies. Assuming you use yarn
4949

5050
```
5151
yarn add @feast-dev/feast-ui
52-
yarn add @elastic/eui @elastic/datemath @emotion/react moment prop-types inter-ui react-query react-router-dom use-query-params zod typescript query-string d3 @types/d3
52+
# For custom UI using the Elastic UI Framework (optional):
53+
yarn add @elastic/eui
54+
# For general custom styling (optional):
55+
yarn add @emotion/react
5356
```
5457

5558
Edit `index.js` in the React app to use Feast UI.

‎ui/README.md‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,14 @@ Start with bootstrapping a React app with `create-react-app`
2121
npx create-react-app your-feast-ui
2222
```
2323

24-
Then, in your app folder, install Feast UI and its peer dependencies. Assuming you use yarn
24+
Then, in your app folder, install Feast UI and optionally its peer dependencies. Assuming you use yarn
2525

2626
```
2727
yarn add @feast-dev/feast-ui
28-
yarn add @elastic/eui @elastic/datemath @emotion/react moment prop-types inter-ui react-query react-router-dom use-query-params zod typescript query-string d3 @types/d3
28+
# For custom UI using the Elastic UI Framework (optional):
29+
yarn add @elastic/eui
30+
# For general custom styling (optional):
31+
yarn add @emotion/react
2932
```
3033

3134
Edit `index.js` in the React app to use Feast UI.

‎ui/package.json‎

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,18 @@
99
"types": "./dist/FeastUI.d.ts",
1010
"module": "./dist/feast-ui.module.js",
1111
"peerDependencies": {
12-
"@elastic/datemath": "^5.0.3",
1312
"@elastic/eui": "^55.0.1",
1413
"@emotion/react": "^11.7.1",
15-
"d3": "^7.3.0",
16-
"inter-ui": "^3.19.3",
17-
"moment": "^2.29.1",
18-
"prop-types": "^15.8.1",
19-
"query-string": "^7.1.1",
2014
"react": "^17.0.2",
21-
"react-dom": "^17.0.2",
22-
"react-query": "^3.34.12",
23-
"react-router-dom": "<6.4.0",
24-
"react-scripts": "^5.0.0",
25-
"use-query-params": "^1.2.3",
26-
"zod": "^3.11.6"
15+
"react-dom": "^17.0.2"
16+
},
17+
"peerDependenciesMeta": {
18+
"@elastic/eui": {
19+
"optional": true
20+
},
21+
"@emotion/react": {
22+
"optional": true
23+
}
2724
},
2825
"dependencies": {
2926
"@elastic/datemath": "^5.0.3",

0 commit comments

Comments
 (0)