Repository navigation
Commit 8fdcee7
fix: Log ODFV materialization skips instead of printing them (#7117)
_materialize_odfv gives up on five conditions and returns without
materializing. Each one printed to stdout with a hand-rolled [WARNING]
prefix, so a user's logging configuration could not silence, redirect
or capture it. The module already has _logger and uses it for every
other warning.
Signed-off-by: VenishPaneliya <[email protected]>
Co-authored-by: Shuchu Han <[email protected]>1 parent 0811002 commit 8fdcee7
2 files changed
Lines changed: 48 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2404 | 2404 | | |
2405 | 2405 | | |
2406 | 2406 | | |
2407 | | - | |
2408 | | - | |
| 2407 | + | |
| 2408 | + | |
| 2409 | + | |
2409 | 2410 | | |
2410 | 2411 | | |
2411 | 2412 | | |
| |||
2432 | 2433 | | |
2433 | 2434 | | |
2434 | 2435 | | |
2435 | | - | |
2436 | | - | |
| 2436 | + | |
| 2437 | + | |
| 2438 | + | |
| 2439 | + | |
2437 | 2440 | | |
2438 | 2441 | | |
2439 | 2442 | | |
2440 | 2443 | | |
2441 | | - | |
2442 | | - | |
| 2444 | + | |
| 2445 | + | |
| 2446 | + | |
| 2447 | + | |
| 2448 | + | |
2443 | 2449 | | |
2444 | 2450 | | |
2445 | 2451 | | |
2446 | 2452 | | |
2447 | | - | |
2448 | | - | |
| 2453 | + | |
| 2454 | + | |
| 2455 | + | |
| 2456 | + | |
2449 | 2457 | | |
2450 | 2458 | | |
2451 | 2459 | | |
| |||
2474 | 2482 | | |
2475 | 2483 | | |
2476 | 2484 | | |
2477 | | - | |
2478 | | - | |
| 2485 | + | |
| 2486 | + | |
| 2487 | + | |
| 2488 | + | |
2479 | 2489 | | |
2480 | 2490 | | |
2481 | 2491 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
| 3 | + | |
2 | 4 | | |
3 | 5 | | |
4 | 6 | | |
| |||
181 | 183 | | |
182 | 184 | | |
183 | 185 | | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
0 commit comments