Skip to content

Commit 7e66a2e

Browse files
jialsjials
authored
fix: Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling (#6315)
* fix: Use set() instead of [] for set-typed variables in SnowflakeRegistry._sync_feast_metadata_to_projects_table Signed-off-by: Jia Le <[email protected]> * fix: Resolve init ordering, infinite recursion, and column casing bugs in SnowflakeRegistry Signed-off-by: Jia Le <[email protected]> * test: Add snowflake_registry fixture to integration registry tests Signed-off-by: Jia Le <[email protected]> * ci: Add snowflake_registry to CI filter and exclude from non-Snowflake test targets Signed-off-by: Jia Le <[email protected]> * fix: Remove leftover private key kwargs before passing to snowflake.connector.connect Signed-off-by: Jia Le <[email protected]> * fix: correct set type hints in _sync_feast_metadata_to_projects_table Signed-off-by: Jia Le <[email protected]> * fix: resolve mypy type errors in SnowflakeRegistry cache Signed-off-by: Jia Le <[email protected]> * test: add xdist_group mark to snowflake_registry Signed-off-by: Jia Le <[email protected]> --------- Signed-off-by: Jia Le <[email protected]>
1 parent dca57e8 commit 7e66a2e

7 files changed

Lines changed: 269 additions & 91 deletions

File tree

‎.github/fork_workflows/fork_pr_integration_tests_snowflake.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
SNOWFLAKE_CI_WAREHOUSE: ${{ secrets.SNOWFLAKE_CI_WAREHOUSE }}
7373
# Run only Snowflake BigQuery and File tests without dynamo and redshift tests.
7474
run: |
75-
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "Snowflake and not dynamo and not Redshift and not Bigquery and not gcp and not minio_registry"
75+
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "(Snowflake or snowflake_registry) and not dynamo and not Redshift and not Bigquery and not gcp and not minio_registry"
7676
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "File and not dynamo and not Redshift and not Bigquery and not gcp and not minio_registry"
7777
- name: Minimize uv cache
7878
run: uv cache prune --ci

‎.secrets.baseline‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Makefile‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,7 @@ test-python-universal-spark: ## Run Python Spark integration tests
282282
not test_push_features_to_offline_store.py and \
283283
not gcs_registry and \
284284
not s3_registry and \
285+
not snowflake_registry and \
285286
not test_universal_types and \
286287
not test_snowflake" \
287288
sdk/python/tests
@@ -316,6 +317,7 @@ test-python-universal-trino: ## Run Python Trino integration tests
316317
not test_push_features_to_offline_store.py and \
317318
not gcs_registry and \
318319
not s3_registry and \
320+
not snowflake_registry and \
319321
not test_universal_types and \
320322
not test_snowflake" \
321323
sdk/python/tests
@@ -331,6 +333,7 @@ test-python-universal-mssql: ## Run Python MSSQL integration tests
331333
python -m pytest -n 8 --integration \
332334
-k "not gcs_registry and \
333335
not s3_registry and \
336+
not snowflake_registry and \
334337
not test_lambda_materialization and \
335338
not test_snowflake and \
336339
not test_historical_features_persisting and \
@@ -364,6 +367,7 @@ test-python-universal-athena: ## Run Python Athena integration tests
364367
not test_historical_retrieval_fails_on_validation and \
365368
not gcs_registry and \
366369
not s3_registry and \
370+
not snowflake_registry and \
367371
not test_snowflake" \
368372
sdk/python/tests
369373

@@ -384,6 +388,7 @@ test-python-universal-postgres-offline: ## Run Python Postgres integration tests
384388
not test_push_features_to_offline_store and \
385389
not gcs_registry and \
386390
not s3_registry and \
391+
not snowflake_registry and \
387392
not test_snowflake and \
388393
not test_spark" \
389394
sdk/python/tests
@@ -405,6 +410,7 @@ test-python-universal-postgres-offline: ## Run Python Postgres integration tests
405410
not test_push_features_to_offline_store and \
406411
not gcs_registry and \
407412
not s3_registry and \
413+
not snowflake_registry and \
408414
not test_snowflake and \
409415
not test_spark" \
410416
sdk/python/tests
@@ -427,6 +433,7 @@ test-python-universal-postgres-online: ## Run Python Postgres integration tests
427433
not test_push_features_to_offline_store and \
428434
not gcs_registry and \
429435
not s3_registry and \
436+
not snowflake_registry and \
430437
not test_universal_types and \
431438
not test_snowflake" \
432439
sdk/python/tests
@@ -446,6 +453,7 @@ test-python-universal-postgres-online: ## Run Python Postgres integration tests
446453
not test_push_features_to_offline_store and \
447454
not gcs_registry and \
448455
not s3_registry and \
456+
not snowflake_registry and \
449457
not test_universal_types and \
450458
not test_validation and \
451459
not test_spark_materialization_consistency and \
@@ -468,6 +476,7 @@ test-python-universal-mysql-online: ## Run Python MySQL integration tests
468476
not test_push_features_to_offline_store and \
469477
not gcs_registry and \
470478
not s3_registry and \
479+
not snowflake_registry and \
471480
not test_universal_types and \
472481
not test_snowflake" \
473482
sdk/python/tests
@@ -498,6 +507,7 @@ test-python-universal-hazelcast: ## Run Python Hazelcast integration tests
498507
not test_push_features_to_offline_store and \
499508
not gcs_registry and \
500509
not s3_registry and \
510+
not snowflake_registry and \
501511
not test_universal_types and \
502512
not test_snowflake" \
503513
sdk/python/tests
@@ -516,6 +526,7 @@ test-python-universal-cassandra-no-cloud-providers: ## Run Python Cassandra inte
516526
not test_nullable_online_store and \
517527
not gcs_registry and \
518528
not s3_registry and \
529+
not snowflake_registry and \
519530
not test_snowflake" \
520531
sdk/python/tests
521532

@@ -534,6 +545,7 @@ test-python-universal-elasticsearch-online: ## Run Python Elasticsearch online s
534545
not test_push_features_to_offline_store and \
535546
not gcs_registry and \
536547
not s3_registry and \
548+
not snowflake_registry and \
537549
not test_universal_types and \
538550
not test_snowflake" \
539551
sdk/python/tests
@@ -553,6 +565,7 @@ test-python-universal-mongodb-online: ## Run Python MongoDB online store integra
553565
not test_push_features_to_offline_store and \
554566
not gcs_registry and \
555567
not s3_registry and \
568+
not snowflake_registry and \
556569
not test_universal_types and \
557570
not test_snowflake" \
558571
sdk/python/tests
@@ -573,6 +586,7 @@ test-python-universal-singlestore-online: ## Run Python Singlestore online store
573586
-k "not test_universal_cli and \
574587
not gcs_registry and \
575588
not s3_registry and \
589+
not snowflake_registry and \
576590
not test_snowflake" \
577591
sdk/python/tests
578592

@@ -607,6 +621,7 @@ test-python-universal-couchbase-offline: ## Run Python Couchbase offline store i
607621
not test_push_features_to_offline_store and \
608622
not gcs_registry and \
609623
not s3_registry and \
624+
not snowflake_registry and \
610625
not test_snowflake and \
611626
not test_universal_types" \
612627
sdk/python/tests
@@ -626,6 +641,7 @@ test-python-universal-couchbase-online: ## Run Python Couchbase online store int
626641
not test_push_features_to_offline_store and \
627642
not gcs_registry and \
628643
not s3_registry and \
644+
not snowflake_registry and \
629645
not test_universal_types and \
630646
not test_snowflake" \
631647
sdk/python/tests

0 commit comments

Comments
 (0)