Skip to content

Commit 3b8892d

Browse files
larrysingleton007larrysingleton007
committed
fix: Rename runtime version response field
Signed-off-by: Larry Singleton <[email protected]>
1 parent b6c48aa commit 3b8892d

8 files changed

Lines changed: 14 additions & 16 deletions

File tree

‎docs/reference/feature-servers/registry-server.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ Most endpoints support these common query parameters:
6262
- **Response Example**:
6363
```json
6464
{
65-
"feast_version": "0.66.0"
65+
"version": "0.66.0"
6666
}
6767
```
6868

‎sdk/python/feast/api/registry/rest/system.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
class VersionResponse(BaseModel):
1010
"""Runtime version information for the Feast server."""
1111

12-
feast_version: str
12+
version: str
1313

1414

1515
def get_system_router() -> APIRouter:
@@ -18,6 +18,6 @@ def get_system_router() -> APIRouter:
1818
@router.get("/version", response_model=VersionResponse, tags=["System"])
1919
def get_feast_version() -> VersionResponse:
2020
"""Return the installed Feast package version for this process."""
21-
return VersionResponse(feast_version=get_version())
21+
return VersionResponse(version=get_version())
2222

2323
return router

‎sdk/python/tests/unit/api/test_system.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def test_version_endpoint_returns_runtime_package_version(version: str) -> None:
1616
response = TestClient(app).get("/version")
1717

1818
assert response.status_code == 200
19-
assert response.json() == {"feast_version": version}
19+
assert response.json() == {"version": version}
2020

2121

2222
def test_version_endpoint_inherits_application_authentication() -> None:

‎sdk/python/tests/unit/test_ui_server.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def test_ui_server_exposes_version_under_rest_api(ui_app_with_registry):
113113
response = client.get("/api/v1/version")
114114

115115
assertpy.assert_that(response.status_code).is_equal_to(EXPECTED_SUCCESS_STATUS)
116-
assertpy.assert_that(response.json()).is_equal_to({"feast_version": "1.2.3"})
116+
assertpy.assert_that(response.json()).is_equal_to({"version": "1.2.3"})
117117

118118

119119
def test_ui_server_health_endpoint_with_unavailable_registry(ui_app_without_registry):

‎ui/src/components/FeastVersion.test.tsx‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ const renderVersion = () => {
3232

3333
test("renders the running Feast version", async () => {
3434
server.use(
35-
http.get("/api/v1/version", () =>
36-
HttpResponse.json({ feast_version: "1.2.3" }),
37-
),
35+
http.get("/api/v1/version", () => HttpResponse.json({ version: "1.2.3" })),
3836
);
3937

4038
renderVersion();
@@ -45,7 +43,7 @@ test("renders the running Feast version", async () => {
4543
test("renders an explicit unknown runtime version", async () => {
4644
server.use(
4745
http.get("/api/v1/version", () =>
48-
HttpResponse.json({ feast_version: "unknown" }),
46+
HttpResponse.json({ version: "unknown" }),
4947
),
5048
);
5149

@@ -74,7 +72,7 @@ test("hides a malformed version response", async () => {
7472
server.use(
7573
http.get("/api/v1/version", () => {
7674
requestHandled = true;
77-
return HttpResponse.json({ version: "1.2.3" });
75+
return HttpResponse.json({ feast_version: "1.2.3" });
7876
}),
7977
);
8078

‎ui/src/components/FeastVersion.tsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,16 @@ const FeastVersion = ({ registryPath }: { registryPath: string }) => {
1010
isLoading ||
1111
isError ||
1212
!data ||
13-
typeof data.feast_version !== "string" ||
14-
data.feast_version.length === 0
13+
typeof data.version !== "string" ||
14+
data.version.length === 0
1515
) {
1616
return null;
1717
}
1818

1919
const label =
20-
data.feast_version === "unknown"
20+
data.version === "unknown"
2121
? "Feast version unknown"
22-
: `Feast v${data.feast_version}`;
22+
: `Feast v${data.version}`;
2323

2424
return (
2525
<EuiText size="xs" color="subdued">

‎ui/src/mocks/handlers.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ const restPermissions = http.get("/api/v1/permissions", () =>
120120
);
121121

122122
const restVersion = http.get("/api/v1/version", () =>
123-
HttpResponse.json({ feast_version: "0.66.0" }),
123+
HttpResponse.json({ version: "0.66.0" }),
124124
);
125125

126126
// Detail endpoints

‎ui/src/queries/useFeastVersion.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { useDataMode } from "../contexts/DataModeContext";
44
import restFetch from "./restApiClient";
55

66
interface FeastVersionResponse {
7-
feast_version: string;
7+
version: string;
88
}
99

1010
const useFeastVersion = (registryPath: string) => {

0 commit comments

Comments
 (0)