Skip to content

Commit 1370aed

Browse files
author
Vitaly Sergeyev
committed
renaming param
Signed-off-by: Vitaly Sergeyev <[email protected]>
1 parent 4f2388f commit 1370aed

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

‎sdk/python/feast/online_response.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def __init__(self, online_response_proto: GetOnlineFeaturesResponse):
4646
del result.event_timestamps[idx]
4747
break
4848

49-
def to_dict(self, is_with_event_timestamps: bool = False) -> Dict[str, Any]:
49+
def to_dict(self, include_event_timestamps: bool = False) -> Dict[str, Any]:
5050
"""
5151
Converts GetOnlineFeaturesResponse features into a dictionary form.
5252
@@ -63,7 +63,7 @@ def to_dict(self, is_with_event_timestamps: bool = False) -> Dict[str, Any]:
6363
else:
6464
response[feature_ref].append(native_type_value)
6565

66-
if is_with_event_timestamps:
66+
if include_event_timestamps:
6767
event_ts = result.event_timestamps[idx].seconds
6868
timestamp_ref = feature_ref + TIMESTAMP_POSTFIX
6969
if timestamp_ref not in response:
@@ -73,12 +73,12 @@ def to_dict(self, is_with_event_timestamps: bool = False) -> Dict[str, Any]:
7373

7474
return response
7575

76-
def to_df(self, is_with_event_timestamps: bool = False) -> pd.DataFrame:
76+
def to_df(self, include_event_timestamps: bool = False) -> pd.DataFrame:
7777
"""
7878
Converts GetOnlineFeaturesResponse features into Panda dataframe form.
7979
8080
Args:
8181
is_with_event_timestamps: bool Optionally include feature timestamps in the dataframe
8282
"""
8383

84-
return pd.DataFrame(self.to_dict(is_with_event_timestamps))
84+
return pd.DataFrame(self.to_dict(include_event_timestamps))

0 commit comments

Comments
 (0)