Skip to content

Commit 0d1c37c

Browse files
committed
Fix push merge
Signed-off-by: Danny Chiao <[email protected]>
1 parent 825e2fd commit 0d1c37c

2 files changed

Lines changed: 11 additions & 27 deletions

File tree

‎sdk/python/feast/feature_store.py‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -533,12 +533,12 @@ def _plan(
533533
... batch_source=driver_hourly_stats,
534534
... )
535535
>>> registry_diff, infra_diff, new_infra = fs._plan(RepoContents(
536-
... data_sources={driver_hourly_stats},
537-
... feature_views={driver_hourly_stats_view},
538-
... on_demand_feature_views=set(),
539-
... request_feature_views=set(),
540-
... entities={driver},
541-
... feature_services=set())) # register entity and feature view
536+
... data_sources=[driver_hourly_stats],
537+
... feature_views=[driver_hourly_stats_view],
538+
... on_demand_feature_views=list(),
539+
... request_feature_views=list(),
540+
... entities=[driver],
541+
... feature_services=list())) # register entity and feature view
542542
"""
543543
# Validate and run inference on all the objects to be registered.
544544
self._validate_all_feature_views(

‎sdk/python/tests/unit/test_data_sources.py‎

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,10 @@
99

1010
def test_push_with_batch():
1111
push_source = PushSource(
12-
name="test",
13-
schema=[Field(name="f1", dtype=Float32), Field(name="f2", dtype=Bool)],
14-
timestamp_field="event_timestamp",
15-
batch_source=BigQuerySource(table="test.test"),
12+
name="test", batch_source=BigQuerySource(table="test.test"),
1613
)
1714
push_source_proto = push_source.to_proto()
1815
assert push_source_proto.HasField("batch_source")
19-
assert push_source_proto.timestamp_field is not None
20-
assert push_source_proto.push_options is not None
2116

2217
push_source_unproto = PushSource.from_proto(push_source_proto)
2318

@@ -51,28 +46,17 @@ def test_request_source_primitive_type_to_proto():
5146

5247
def test_hash():
5348
push_source_1 = PushSource(
54-
name="test",
55-
schema=[Field(name="f1", dtype=Float32), Field(name="f2", dtype=Bool)],
56-
timestamp_field="event_timestamp",
57-
batch_source=BigQuerySource(table="test.test"),
49+
name="test", batch_source=BigQuerySource(table="test.test"),
5850
)
5951
push_source_2 = PushSource(
60-
name="test",
61-
schema=[Field(name="f1", dtype=Float32), Field(name="f2", dtype=Bool)],
62-
timestamp_field="event_timestamp",
63-
batch_source=BigQuerySource(table="test.test"),
52+
name="test", batch_source=BigQuerySource(table="test.test"),
6453
)
6554
push_source_3 = PushSource(
66-
name="test",
67-
schema=[Field(name="f1", dtype=Float32)],
68-
timestamp_field="event_timestamp",
69-
batch_source=BigQuerySource(table="test.test"),
55+
name="test", batch_source=BigQuerySource(table="test.test2"),
7056
)
7157
push_source_4 = PushSource(
7258
name="test",
73-
schema=[Field(name="f1", dtype=Float32)],
74-
timestamp_field="event_timestamp",
75-
batch_source=BigQuerySource(table="test.test"),
59+
batch_source=BigQuerySource(table="test.test2"),
7660
description="test",
7761
)
7862

0 commit comments

Comments
 (0)