fix: Publish destination and build script on Windows#1593
Open
alexanderroidl wants to merge 2 commits intofb55:masterfrom
Open
fix: Publish destination and build script on Windows#1593alexanderroidl wants to merge 2 commits intofb55:masterfrom
alexanderroidl wants to merge 2 commits intofb55:masterfrom
Conversation
alexanderroidl
commented
Jun 28, 2025
| }, | ||
| "files": [ | ||
| "dist", | ||
| "src" |
Author
There was a problem hiding this comment.
To deliver the source code to users Git/GitHub should be used. The source files should not exported for a NPM publish.
alexanderroidl
commented
Jun 28, 2025
| "import": "./lib/esm/index.js" | ||
| }, | ||
| "files": [ | ||
| "dist", |
Author
There was a problem hiding this comment.
The dist directory does not exist and can not be built right now as there is no build script for it.
alexanderroidl
commented
Jun 28, 2025
| "format:prettier": "npm run prettier -- --write", | ||
| "prettier": "prettier '**/*.{ts,md,json,yml}'", | ||
| "build": "npm run build:cjs && npm run build:esm", | ||
| "build:cjs": "tsc --sourceRoot https://raw.githubusercontent.com/fb55/css-select/$(git rev-parse HEAD)/src/", |
Author
There was a problem hiding this comment.
The URL needs to be wrapped in quotation marks to function in Windows+Git Bash.
This was referenced Jun 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recently commited commit 9421ec9 lead to the
libdirectory not being part of the published package anymore, which results in required files not being found and eventually failure.For example when building an Angular application:
A
distdirectory appears to be used to publish:9421ec9#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R26
But it can not be found in any shape or form inside the repository. There is no reference to such a directory in any file. Is there a build script which has not been pushed yet that fails to export the missing files perhaps?