Handle empty optional ONNX inputs in shape parsing#1507
Open
niteshg97 wants to merge 3 commits into
Open
Conversation
Update docstring to clarify that only non-empty input shapes are returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1266.
In ONNX, optional inputs that are not provided are represented by an empty string (
""). For example, aResizenode can have inputs like : ['Quant_0_out0', '', 'Resize_0_param0']where the second entry corresponds to the optional ROI input.
At the moment,
get_input_shape()attempts to resolve the shape for every input, including the empty placeholder. Since an empty string does not correspond to a valid tensor, this results in,RuntimeError: Could not find the shape for input
This change simply skips empty input placeholders while keeping the existing behavior unchanged for valid input names. If a non empty input is missing its shape, the same error is still raised.
Changes
get_input_shape().Resizenode with the optional ROI input omitted.Testing