[increment_version_number] update MARKETING_VERSION build setting by andredestro · Pull Request #30031 · fastlane/fastlane

andredestro · 2026-05-12T16:26:25Z

Checklist

I've run bundle exec rspec from the root directory to see all new and existing tests pass
I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
I've read the Contribution Guidelines
I've updated the documentation if necessary.
I've added or updated relevant unit tests.

Motivation and Context

PR #30011 fixed resolving $(MARKETING_VERSION) when reading the current version, but agvtool new-marketing-version can still leave the MARKETING_VERSION build setting unchanged in modern Xcode projects.

Description

This syncs the new version back to the Xcode project's MARKETING_VERSION build setting after running agvtool.

The project is only saved when MARKETING_VERSION already exists.

Testing Steps

bundle exec rspec fastlane/spec/actions_specs/increment_version_number_action_spec.rb

28 examples, 0 failures

RUBOCOP_CACHE_ROOT=/private/tmp/rubocop_cache bundle exec rubocop fastlane/lib/fastlane/actions/increment_version_number.rb fastlane/spec/actions_specs/increment_version_number_action_spec.rb

2 files inspected, no offenses detected

iBotPeaches · 2026-05-12T18:50:36Z

thanks! I wonder if we have an official existing action to do the replacement in xcodeproj, so we don't have to double up logic in this action that exists elsewhere.

andredestro · 2026-05-13T10:05:40Z

thanks! I wonder if we have an official existing action to do the replacement in xcodeproj, so we don't have to double up logic in this action that exists elsewhere.

Good question. I checked the existing xcodeproj-related actions, but I couldn’t find a public action/helper that updates arbitrary build settings like MARKETING_VERSION directly. The closest actions are increment_version_number / increment_build_number, but they rely on agvtool/plist behavior, which is what this change is trying to avoid for generated Info.plist projects.
Happy to extract this into a shared helper if preferred.

iBotPeaches · 2026-05-15T10:08:49Z

Good question. I checked the existing xcodeproj-related actions, but I couldn’t find a public action/helper that updates arbitrary build settings like MARKETING_VERSION directly. The closest actions are increment_version_number / increment_build_number, but they rely on agvtool/plist behavior, which is what this change is trying to avoid for generated Info.plist projects. Happy to extract this into a shared helper if preferred.

Yeah I think this needs a little cleanup and if you are up for it. I don't like how we are reaching into get_version_number solely to get an xcodeproj project via get_project.

That to me probably should have been in xcodeproj_helper in the core so all Actions have an ability to get an XcodeProj class in a standard way.

Then saying that, a method in the root xcodeproj_helper that takes that Project, then a key and value seems like a good standard to start. So we can evolve match, etc in future to make some changes that other actions are presently needed for. I think an official internal function that other actions can call would boost its strength instead of the present fractured setup we have now between these similar actions.

Does that make sense and are you up for it?

andredestro · 2026-05-15T12:03:45Z

Does that make sense and are you up for it?

Yep, that makes sense. I moved the Xcode project lookup into Fastlane::Helper::XcodeprojHelper and added a shared helper for updating a build setting across the project and targets.

increment_version_number now uses those helpers instead of reaching into GetVersionNumberAction, while GetVersionNumberAction.get_project! delegates to the helper to keep existing behavior intact.

I also added specs for the new helper methods and updated the increment_version_number specs.

Validated locally with the focused specs and RuboCop. I also tested the increment_version_number(version_number: ...) flow against a copy of a real project that stores MARKETING_VERSION in the Xcode project, and it updates the setting correctly.

Copilot

Pull request overview

This PR updates increment_version_number to sync version changes back into Xcode project build settings, addressing MARKETING_VERSION-based projects where agvtool does not update the build setting directly.

Changes:

Adds shared Xcode project loading and build-setting update helpers.
Updates increment_version_number to save MARKETING_VERSION after agvtool.
Adds unit coverage for project loading and build-setting synchronization.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`fastlane/lib/fastlane/actions/increment_version_number.rb`	Syncs version build settings after running `agvtool`.
`fastlane/lib/fastlane/actions/get_version_number.rb`	Reuses shared Xcode project loading helper.
`fastlane/lib/fastlane/helper/xcodeproj_helper.rb`	Adds project loading and build-setting update helpers.
`fastlane/spec/actions_specs/increment_version_number_action_spec.rb`	Adds tests for MARKETING_VERSION sync behavior.
`fastlane/spec/helper/xcodeproj_helper_spec.rb`	Adds tests for new Xcode project helper methods.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

andredestro · 2026-05-18T08:57:21Z

Addressed the Copilot review comments.

The helper now handles build settings stored in a base .xcconfig when the setting is not present inline in the pbxproj.

The verbose message now preserves the original format returned by agvtool, so ${MARKETING_VERSION} stays as ${...} in the log.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

fastlane/lib/fastlane/helper/xcodeproj_helper.rb:94

Writing .xcconfig files here creates a new kind of version-related modification, but the action never records these paths in Actions.add_modified_files. commit_version_bump only expects the pbxproj/Info.plist files plus paths from MODIFIED_FILES, so lanes that run it after this action can now fail with the updated .xcconfig reported as an unexpected change.

        File.write(path, new_content) if updated

…settings

iBotPeaches · 2026-05-18T12:40:19Z

Ah this is a bit larger now with the xcconfig stuff - let me read up

github-actions

Hey @andredestro 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"

github-actions

Congratulations! 🎉 This was released as part of fastlane 2.235.0 🚀

[increment_version_number] update MARKETING_VERSION build setting

30f113a

github-actions Bot added the tool: action label May 12, 2026

[increment_version_number] move Xcode project updates to XcodeprojHelper

0656719

iBotPeaches requested a review from Copilot May 15, 2026 13:31

Copilot started reviewing on behalf of iBotPeaches May 15, 2026 13:31 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

Comment thread fastlane/lib/fastlane/helper/xcodeproj_helper.rb Outdated

Comment thread fastlane/lib/fastlane/actions/increment_version_number.rb Outdated

andredestro requested a review from Copilot May 18, 2026 08:57

Copilot started reviewing on behalf of andredestro May 18, 2026 08:58 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread fastlane/lib/fastlane/helper/xcodeproj_helper.rb Outdated

Comment thread fastlane/lib/fastlane/helper/xcodeproj_helper.rb Outdated

andredestro force-pushed the fix/increment-version-marketing-version branch 2 times, most recently from 8639bad to 8ba61cf Compare May 18, 2026 09:42

andredestro requested a review from Copilot May 18, 2026 09:51

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread fastlane/lib/fastlane/actions/increment_version_number.rb Outdated

Comment thread fastlane/lib/fastlane/helper/xcodeproj_helper.rb Outdated

Comment thread fastlane/lib/fastlane/helper/xcodeproj_helper.rb Outdated

andredestro force-pushed the fix/increment-version-marketing-version branch from 8ba61cf to 5685309 Compare May 18, 2026 10:30

andredestro requested a review from Copilot May 18, 2026 10:31

Copilot started reviewing on behalf of andredestro May 18, 2026 10:31 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread fastlane/lib/fastlane/actions/increment_version_number.rb

Comment thread fastlane/lib/fastlane/helper/xcodeproj_helper.rb Outdated

[increment_version_number] sync MARKETING_VERSION with Xcode project …

ed82f18

…settings

andredestro force-pushed the fix/increment-version-marketing-version branch from 5685309 to ed82f18 Compare May 18, 2026 10:57

iBotPeaches approved these changes May 21, 2026

View reviewed changes

iBotPeaches merged commit 47c965c into fastlane:master May 21, 2026
9 checks passed

github-actions Bot added the status: included-in-next-release label May 21, 2026

github-actions Bot reviewed May 21, 2026

View reviewed changes

github-actions Bot mentioned this pull request May 25, 2026

Version bump to 2.235.0 #30050

Merged

github-actions Bot reviewed May 26, 2026

View reviewed changes

github-actions Bot added status: released and removed status: included-in-next-release labels May 26, 2026

Uh oh!

Conversation

andredestro commented May 12, 2026

Checklist

Motivation and Context

Description

Testing Steps

Uh oh!

iBotPeaches commented May 12, 2026

Uh oh!

andredestro commented May 13, 2026

Uh oh!

iBotPeaches commented May 15, 2026

Uh oh!

andredestro commented May 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

andredestro commented May 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

iBotPeaches commented May 18, 2026

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants