[ci] fix flaky test due to time shift#30030
Merged
Merged
Conversation
iBotPeaches
force-pushed
the
flaky-time-test
branch
from
6955c40 to
8e0a164
Compare
lacostej
approved these changes
May 21, 2026
Collaborator
|
Number of days since a time-related bug was discovered: -1 ;) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @iBotPeaches 👋
Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.
Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"
Contributor
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.235.0 🚀
github-actions
Bot
added
status: released
and removed
status: included-in-next-release
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I was working at night my time (8pm Eastern) - usually I work at 5-7am Eastern and I had a test failure that was so odd.
The issue was the day changed between the assertions and execution (I guess the time changing).
Solution
We change a static reference into a let block so its resolved at runtime (not start time). This means even though we are mocking time - they will be closer together. Since test suite can take 1-10min
We mock Time