Skip to content

[supply] fix crash if no release on track#30029

Merged
iBotPeaches merged 1 commit into
masterfrom
issue-21496
May 21, 2026
Merged

[supply] fix crash if no release on track#30029
iBotPeaches merged 1 commit into
masterfrom
issue-21496

Conversation

@iBotPeaches

@iBotPeaches iBotPeaches commented May 10, 2026

Copy link
Copy Markdown
Member

Problem

If you have no releases on a track - you get nill and then crash.

NoMethodError: [!] undefined method size' for nil:NilClass supply/lib/supply/uploader.rb:119:in fetch_track_and_release!'

Solution

Fall back to an empty array + add a test to prevent regressions.

fixes: #21530

@github-actions github-actions Bot added the tool: supply upload_to_playstore label May 10, 2026
@iBotPeaches iBotPeaches merged commit ca73fac into master May 21, 2026
14 of 15 checks passed
@iBotPeaches iBotPeaches deleted the issue-21496 branch May 21, 2026 10:43

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @iBotPeaches 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.235.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

undefined method `size' for nil:NilClass

2 participants