[deliver] improve documentation & clarify on territory_ids behavior for upload_price_tier#30019
Conversation
iBotPeaches
left a comment
iBotPeaches
left a comment
There was a problem hiding this comment.
There is a comment in docs that explains this is intentional.
territory_ids = nil # nil won't update app's territory_ids, empty array would remove app from sale.
So this would break that.
|
Thanks for the review, that makes sense. I missed that the I agree this PR is too strong because it blocks a valid use case: intentionally passing an empty I can close/rework this as a non-security UX/documentation improvement instead, e.g. making the success message more explicit when What would you prefer? |
|
Yeah I think peeking documentation and ensuring this is documented well could be all we need. |
orbisai0security
changed the title
Co-Authored-By: Claude Opus 4.6 <[email protected]>
orbisai0security
force-pushed
the
fix-v-004-upload-price-tier-empty-territory-ids
branch
from
7975fc0 to
2569c05
Compare
orbisai0security
changed the title
iBotPeaches
changed the title
iBotPeaches
left a comment
iBotPeaches
left a comment
There was a problem hiding this comment.
Thanks. All in all I don't think this is truly needed as it amounted to just rewording a sentence, but since the comment on same line of variable is easier to miss. Going forward.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @orbisai0security 👋
Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.
Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"
…or upload_price_tier (fastlane#30019) Co-authored-by: Claude Opus 4.6 <[email protected]>
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.234.0 🚀
github-actions
Bot
added
status: released
and removed
status: included-in-next-release
labels
2 participants
Summary
Clarifies the documented behavior of
territory_idswhen updating app pricing.The existing behavior intentionally distinguishes between:
nil: leave existing territory availability unchanged[]: remove the app from sale in all territoriesThis PR does not change runtime behavior. It only improves documentation/comments so users understand the effect of passing an empty array.
Verification
🤖 Generated with Claude Code