Skip to content

[precheck] add 'nsfw' as blocklisted term#29937

Merged
iBotPeaches merged 3 commits into
fastlane:masterfrom
jtlthe2:29936-add-nsfw-to-blocklist-in-precheck
Mar 16, 2026
Merged

[precheck] add 'nsfw' as blocklisted term#29937
iBotPeaches merged 3 commits into
fastlane:masterfrom
jtlthe2:29936-add-nsfw-to-blocklist-in-precheck

Conversation

@jtlthe2

@jtlthe2 jtlthe2 commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Resolves #29936

Description

Adds the term "nsfw" to precheck's curse word list. It's been flagged a couple times for as violating Guideline 1.1

Testing Steps

Unit tests

@jtlthe2 jtlthe2 changed the title 29936 add nsfw to blocklist in precheck [precheck] add 'nsfw' as blocklisted term Mar 4, 2026
@jtlthe2

jtlthe2 commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

Here's a patch if anyone wants to add this in before the next fastlane release!

git diff --no-prefix 0776a92386583c87828e25ccd31d8227864d02e7 a8d6b75e5c870807625839aece2d2046533bff1c > ~/fastlane-pull-29937.patch

fastlane-pull-29937.patch

@iBotPeaches iBotPeaches left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time I've looked at precheck

Comment thread precheck/lib/precheck/rules/rules_data/curse_word_hashes/en_us.txt
Comment thread precheck/spec/rules/curse_words_rule_spec.rb
@jtlthe2 jtlthe2 requested a review from iBotPeaches March 7, 2026 22:08
Comment thread precheck/spec/rules/curse_words_rule_spec.rb

@iBotPeaches iBotPeaches left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed hash is nsfw (c6603565c5159fbe846a53e991829d452a1546d41150c0d3c73ddbd7f476ee0d)

@iBotPeaches iBotPeaches merged commit 538f129 into fastlane:master Mar 16, 2026
9 checks passed

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jtlthe2 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.233.0 🚀

@github-actions github-actions Bot locked and limited conversation to collaborators Jun 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants