fix: migrate to standard which() helper to prevent ci spam#29933
Merged
Conversation
github-actions
Bot
added
tool: snapshot
tool: frameit
tool: fastlane_core
tool: action
labels
Resolves rubocop Require/MissingRequireStatement offense for the Helper.which method that delegates to FastlaneCore::CommandExecutor. Co-Authored-By: Claude Opus 4.6 <[email protected]>
lacostej
reviewed
Mar 11, 2026
| unless Helper.test? | ||
| UI.message("Install using `brew install appledoc`") | ||
| UI.user_error!("appledoc not installed") if `which appledoc`.length == 0 | ||
| UI.user_error!("appledoc not installed") if Helper.which('appledoc').nil? |
Collaborator
There was a problem hiding this comment.
do we want to use unless Helper.which('appledoc') pattern?
lacostej
reviewed
Mar 11, 2026
Collaborator
|
Note: I didn't flag all potential removal of |
lacostej
approved these changes
Apr 29, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @iBotPeaches 👋
Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.
Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"
Contributor
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.234.0 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reviewing CI on Windows is impossible. Its full of spam.
Solution
Introduce a new helper for
which(system binary) in order to suppress output.