[action] Revert to "-uploadedDate" sort order for app_store_build_num…#29899
Conversation
…ber and latest_testflight_build_number action
|
Ok, made some last tests. My use case still works as expected. #29897 should be fixed too. Can be merged once reviewed. |
|
Thank you! I'll review and cut a release tomorrow if all checks out. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Mik4sa 👋
Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.
Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"
|
Thank you for the fix here @Mik4sa; we are running in an issue which causes our builds can not be uploaded to App Store Connect due to duplicated build numbers. Thank you for tagging a quick release on this @iBotPeaches; greatly appreciated! |
|
I'm not sure what you mean. Is there still a problem for you, or has it been fixed with the latest version 2.232.1? |
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.232.1 🚀
github-actions
Bot
added
status: released
and removed
status: included-in-next-release
labels
|
It was meant as a thank you for fixing the issue so quickly. We will give it a test once it is available on homebrew; but I think it will resolve our issues. |
3 participants
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #29897
Description
Revert the sort order to
-uploadedDate. However, this change alone is insufficient because builds currently being uploaded don't have anuploadedDateyet (it's set toNULL), which would cause them to be sorted to the top. To prevent this, build uploads in theAWAITING_UPLOADstate are excluded.Testing Steps
Check #29897 for details.