[deliver, pilot] Add provider_public_id option for altool uploads#29898
Conversation
|
thanks for starting this! Looks like some test failures, but as you marked it as draft. I'm sure your on it! |
|
@iBotPeaches Now it should be ready for the review. The only issue is that AppVeyor has failed, but I can’t see why. Thanks in advance for reviewing this. |
|
GitHub having major issues today. I think related to that. |
It is still failed, do you think I should close this and reopen a new one? |
|
Any news to when this will be incuded. Will it just fix the issue or will we need to change our pipeline ? |
|
@assembleMHN - Are you confirming this branch fixed the issue you experienced? |
@assembleMHN You will need to pass "provider_public_id" option to your "deliver" and "pilot" commands. |
|
I removed AppVeyor, so if you rebase/merge-master. This should run CI properly now. |
cab2edb to
3a8ce3d
Compare
There was a problem hiding this comment.
Hey @hasancanakgunduz 👋
Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.
Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"
|
@iBotPeaches Any idea when a new version of fastlane will be released that includes this change? Apple's deadline for using Xcode26 is coming up fast (April 28, 2026) and need this addition to be able to comply |
|
I hope soon - I'll give the other maintainers a ping. Waiting on some things. |
|
@kdbdallas-eshow you can update your gemfile to pull from master as a temporary fix im confirmed master works as i have a mobile app deployment pipeline utilizing fastlane |
I did try that and it worked some times. Other attempts would throw other issues. I was thinking it was when new commits were added or something. I will give it another try and if I get the errors report back. Thanks |
|
@kdbdallas-eshow what issues did you see? thanks for your quick response btw |
|
@kdbdallas-eshow i locked my fastlane down to the latest commit and im running to builds right now through github runner |
|
@kdbdallas-eshow it appears stable for me |
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.233.0 🚀
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Xcode 26+ altool requires
--provider-public-idfor multi‑provider accounts using username/app‑password auth. We need a dedicatedprovider_public_idoption while keeping legacy--asc-providersupport for older altool and existingitc_providerusers.Reference: https://keith.github.io/xcode-man-pages/altool.1.html
Description
provider_public_idoption for altool upload/validate--asc-providerbehavior for backward compatibilitybuild_upload_command/build_verify_commandto options hashes to avoid optional‑parameter limitsprovider_public_idin Pilot/Deliver options and docsprovider_public_idTesting Steps
bundle exec rspec ./fastlane_core/spec/itunes_transporter_spec.rb
fixes: #29820