Skip to content

[deliver, pilot] Add provider_public_id option for altool uploads#29898

Merged
iBotPeaches merged 4 commits into
fastlane:masterfrom
hasancanakgunduz:provider-public-id-altool
Mar 26, 2026
Merged

[deliver, pilot] Add provider_public_id option for altool uploads#29898
iBotPeaches merged 4 commits into
fastlane:masterfrom
hasancanakgunduz:provider-public-id-altool

Conversation

@hasancanakgunduz

@hasancanakgunduz hasancanakgunduz commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Xcode 26+ altool requires --provider-public-id for multi‑provider accounts using username/app‑password auth. We need a dedicated provider_public_id option while keeping legacy --asc-provider support for older altool and existing itc_provider users.
Reference: https://keith.github.io/xcode-man-pages/altool.1.html

Description

  • Added provider_public_id option for altool upload/validate
  • Kept legacy --asc-provider behavior for backward compatibility
  • Switched transporter build_upload_command/build_verify_command to options hashes to avoid optional‑parameter limits
  • Documented provider_public_id in Pilot/Deliver options and docs
  • Added altool upload spec for provider_public_id

Testing Steps

bundle exec rspec ./fastlane_core/spec/itunes_transporter_spec.rb

fixes: #29820

@iBotPeaches

Copy link
Copy Markdown
Member

thanks for starting this! Looks like some test failures, but as you marked it as draft. I'm sure your on it!

@hasancanakgunduz hasancanakgunduz marked this pull request as ready for review February 9, 2026 19:05
@hasancanakgunduz

Copy link
Copy Markdown
Contributor Author

@iBotPeaches Now it should be ready for the review. The only issue is that AppVeyor has failed, but I can’t see why. Thanks in advance for reviewing this.

@iBotPeaches

Copy link
Copy Markdown
Member

GitHub having major issues today. I think related to that.

@hasancanakgunduz hasancanakgunduz changed the title Add provider_public_id option for altool uploads [deliver, pilot] Add provider_public_id option for altool uploads Feb 10, 2026
@hasancanakgunduz

Copy link
Copy Markdown
Contributor Author

GitHub having major issues today. I think related to that.

It is still failed, do you think I should close this and reopen a new one?

@assembleMHN

Copy link
Copy Markdown

Any news to when this will be incuded. Will it just fix the issue or will we need to change our pipeline ?

@iBotPeaches

Copy link
Copy Markdown
Member

@assembleMHN - Are you confirming this branch fixed the issue you experienced?

@hasancanakgunduz

hasancanakgunduz commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

Any news to when this will be incuded. Will it just fix the issue or will we need to change our pipeline ?

@assembleMHN You will need to pass "provider_public_id" option to your "deliver" and "pilot" commands.

@iBotPeaches

Copy link
Copy Markdown
Member

I removed AppVeyor, so if you rebase/merge-master. This should run CI properly now.

@hasancanakgunduz hasancanakgunduz force-pushed the provider-public-id-altool branch from cab2edb to 3a8ce3d Compare March 26, 2026 07:51
Comment thread deliver/lib/deliver/options.rb
@iBotPeaches iBotPeaches merged commit d0b5e81 into fastlane:master Mar 26, 2026
9 checks passed

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hasancanakgunduz 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"

@kdbdallas-eshow

Copy link
Copy Markdown

@iBotPeaches Any idea when a new version of fastlane will be released that includes this change? Apple's deadline for using Xcode26 is coming up fast (April 28, 2026) and need this addition to be able to comply

@iBotPeaches

Copy link
Copy Markdown
Member

I hope soon - I'll give the other maintainers a ping. Waiting on some things.

@velevtzvetlin

Copy link
Copy Markdown

@kdbdallas-eshow you can update your gemfile to pull from master as a temporary fix
gem 'fastlane', github: 'fastlane/fastlane', branch: 'master'

im confirmed master works as i have a mobile app deployment pipeline utilizing fastlane

@kdbdallas-eshow

Copy link
Copy Markdown

@kdbdallas-eshow you can update your gemfile to pull from master as a temporary fix

gem 'fastlane', github: 'fastlane/fastlane', branch: 'master'

im confirmed master works as i have a mobile app deployment pipeline utilizing fastlane

I did try that and it worked some times. Other attempts would throw other issues. I was thinking it was when new commits were added or something. I will give it another try and if I get the errors report back. Thanks

@velevtzvetlin

velevtzvetlin commented Apr 17, 2026

Copy link
Copy Markdown

@kdbdallas-eshow what issues did you see? thanks for your quick response btw

@velevtzvetlin

Copy link
Copy Markdown

@kdbdallas-eshow i locked my fastlane down to the latest commit and im running to builds right now through github runner macos-15-xlarge will report back

@velevtzvetlin

Copy link
Copy Markdown

@kdbdallas-eshow it appears stable for me

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.233.0 🚀

@github-actions github-actions Bot locked and limited conversation to collaborators Jun 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Xcode26.2 altool fails with "Failed to determine the appleID from bundleID" message

5 participants