[action] Switch to "build uploads" api for app_store_build_number and latest_testflight_build_number action#29879
Conversation
…ight_build_number action since it's completly based on app_store_build_number action
|
Hey @iBotPeaches is there any chance that we can get this merged too :)? |
|
I think I got caught up researching the API Version, I saw the new endpoint was
and then I thought - there is a single App Store Connect API right? So why would it matter, the entire world upgrades to a new version at once. I then thought maybe Enterprise on-prem is different. Basically looking into I needed to be concerned with that and lost focus. |
|
Ah I see, didn't realized that earlier to be honest. We could add a switch to choose between "builds api" or "builds upload api" but this would add quite of complexity. Another way, in case we can't find an answer to that question, we could use the builds upload api and when there are no new issue regarding that we could keep it that way and only then find another way. |
There was a problem hiding this comment.
Hey @Mik4sa 👋
Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.
Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.232.0 🚀
Fastlane 2.232.0 introduced a regression in latest_testflight_build_number that sorts cfBundleVersion as a string instead of numerically, causing build 9 to rank above build 62 (fastlane/fastlane#29879).
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #29878
Description
While troubleshooting the linked issue #29878 I found that on App Store Connect there are builds and also build uploads. A basic difference is that build uploads show builds that are currently uploaded (which an actual "normal" build isn't showing)
I tested everything with my exactly use case. Using the build uploads api from App Store Connect resulted into the behavior I expected. Everything else should work as before (except that build uploads be taken into account)
Note: The
latest_testflight_build_numberaction uses theapp_store_build_numberaction under the hood, which is why it is also affected by my change. However, no special adjustments were necessary in this regard, as the action could almost be considered an alias, as it appears to me.Note 2: I'm still quite new to fastlane and especially to ruby.
Testing Steps
Test with the following action call / parameters:
While a build is uploading the
app_store_build_numberaction should return the currently uploading build number. Before my change an even older one (from the last completed processed build) was returned.