[ci] remove AppVeyor for Windows tests on GitHub Actions#29876
Conversation
iBotPeaches
force-pushed
the
bye-bye-appveyor
branch
from
7e7a39d to
33d8899
Compare
|
Will have to find who configured AppVeyor, since post-merge we can disable the webhook/configuration it has. I'm guessing its a webhook, but I don't have permission to see that on this repo. |
janpio
left a comment
janpio
left a comment
There was a problem hiding this comment.
I didn't originally configure it, but I think I have enough permissions to clean it up if needed. Feel free to reach out at my lastname @ gmail if you need my attention.
|
@janpio - That sounds great. If you have ability to disable it - lets do it. I had pinged Felix/Josh in Slack, but no response yet. |
|
Disabled the webhook at https://github.com/fastlane/fastlane/settings/hooks/23256640 (Did not delete it, because... you never know.) As I understand it, that should be enough to not trigger the job on PR pushes any more. |
|
Thanks! I'll do a test PR to confirm after dinner and confirm and merge. |
iBotPeaches
changed the title
iBotPeaches
force-pushed
the
bye-bye-appveyor
branch
from
33d8899 to
bb1c023
Compare
|
Confirmed with the rebase here (no failing tests) and confirmed in a new PR: #29929 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @iBotPeaches 👋
Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.
Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.233.0 🚀
github-actions
Bot
added
status: released
and removed
status: included-in-next-release
labels
3 participants
Problem
AppVeyor splits our maintenance burden between CircleCI, GHA and itself. This helps reduce our footprint and have faster builds since our concurrency limit is 1 on AppVeyor.
Solution
Port AppVeyor to GHA with support in future (to remove CircleCI)