Skip to content

[match] Bump minimum version of aws-sdk-s3 dependency to ~> 1.197#29750

Merged
iBotPeaches merged 3 commits into
masterfrom
fix-aws-s3-min-version
Feb 4, 2026
Merged

[match] Bump minimum version of aws-sdk-s3 dependency to ~> 1.197#29750
iBotPeaches merged 3 commits into
masterfrom
fix-aws-s3-min-version

Conversation

@AliSoftware

@AliSoftware AliSoftware commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

In #29704 we started using the new Aws::S3::TransferManager class to fix a deprecation warning.
But that class was only introduced in version 1.197.0 of the aws-sdk-s3 dependency.

Description

This PR bumps the minimum version of the aws-sdk-s3 dependency in our .gemspec to ensure end users use at least version 1.197.0 of the dependency.

Testing Steps

Same testing steps as #29704

@AliSoftware

Copy link
Copy Markdown
Contributor Author

Note

CI failures in this PR that are about Ruby 2.x install failures will be fixed separately once #29734 lands.

@iBotPeaches iBotPeaches left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in Slack. This brings Ruby min to 2.7, which CI is set to 2.6 min presently.

I have no problem with that breakage since I'm working to drop 2 entirely, but we can probably merge after #29734

Bundler found conflicting requirements for the Ruby version:
  In Gemfile:
    fastlane was resolved to 2.228.0, which depends on
      aws-sdk-s3 (~> 1.197) was resolved to 1.203.1, which depends on
        Ruby (>= 2.7)
  Current Ruby version:
    Ruby (= 2.6.3)

@iBotPeaches

Copy link
Copy Markdown
Member

Fixed conflicts - this should be good now.

@iBotPeaches iBotPeaches changed the title Bump minimum version of aws-sdk-s3 dependency to ~> 1.197 [core] Bump minimum version of aws-sdk-s3 dependency to ~> 1.197 Jan 26, 2026
@iBotPeaches iBotPeaches changed the title [core] Bump minimum version of aws-sdk-s3 dependency to ~> 1.197 [match] Bump minimum version of aws-sdk-s3 dependency to ~> 1.197 Jan 26, 2026
@iBotPeaches iBotPeaches merged commit 39f641a into master Feb 4, 2026
14 checks passed
@iBotPeaches iBotPeaches deleted the fix-aws-s3-min-version branch February 4, 2026 17:48

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AliSoftware 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.232.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants