[action][swiftlint] Adds '--progress' flag#21922
Conversation
|
I'm not quite sure why most of the CircleCI tasks fail due to permission issues. Maybe somebody can advise me what to do here? |
I guess, I needed to use the original |
|
Why is this PR lying around for over a year? It is not a major change. @joshdholtz |
|
Bump! |
|
can you merge this? @joshdholtz |
|
This PR was quite old. I merged master into it, to trigger CI so we can see if this is mergable or not. |
There was a problem hiding this comment.
Hey @ObjectiveCesar 👋
Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.
Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.233.0 🚀
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
I think it is a good idea to support the full feature set of a used tool, in this case SwiftLint, inside the fastlane actions. This pull request is a contribution to achieve that goal.
The newly introduced flag
--progressof SwiftLint helps to reduce clutter from the console output. The output is reduced to SwiftLint violations only which makes it much easier to find those inside a console log be it on a local machine or on a CI.Description
I added a new accepted optional argument to the fastlane action 'swiftlint' that will add the '--progress' flag to the SwiftLint command if passed by the action with
true. If the--progressflag is not supported by the current SwiftLint version (first introduced with 0.49.1) the action argument will be ignored. The default value for that argument isfalseto not introduce a different behaviour to previous fastlane versions.Testing Steps
bundle installand/orbundle update(You should have installedbundleralready)Gemfileto usegemspec path: File.expand_path("<PATH_TO_LOCAL_FASTLANE>") instead ofgem fastlane`; replacing <PATH_TO_LOCAL_FASTLANE> with the path where you have the local fastlane repo.bundle exec fastlane run swiftlint progress:trueto see how it works.