Skip to content

[action][swiftlint] Adds '--progress' flag#21922

Merged
iBotPeaches merged 5 commits into
fastlane:masterfrom
ObjectiveCesar:feature/Add_progress_option
Apr 14, 2026
Merged

[action][swiftlint] Adds '--progress' flag#21922
iBotPeaches merged 5 commits into
fastlane:masterfrom
ObjectiveCesar:feature/Add_progress_option

Conversation

@ObjectiveCesar

@ObjectiveCesar ObjectiveCesar commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

I think it is a good idea to support the full feature set of a used tool, in this case SwiftLint, inside the fastlane actions. This pull request is a contribution to achieve that goal.
The newly introduced flag --progress of SwiftLint helps to reduce clutter from the console output. The output is reduced to SwiftLint violations only which makes it much easier to find those inside a console log be it on a local machine or on a CI.

Description

I added a new accepted optional argument to the fastlane action 'swiftlint' that will add the '--progress' flag to the SwiftLint command if passed by the action with true. If the --progress flag is not supported by the current SwiftLint version (first introduced with 0.49.1) the action argument will be ignored. The default value for that argument is false to not introduce a different behaviour to previous fastlane versions.

Testing Steps

  1. Clone the repo, checkout the PR branch
  2. CD into the directory and execute bundle install and/or bundle update (You should have installed bundler already)
  3. CD into you project and edit your projects Gemfile to use gemspec path: File.expand_path("<PATH_TO_LOCAL_FASTLANE>") instead of gem fastlane`; replacing <PATH_TO_LOCAL_FASTLANE> with the path where you have the local fastlane repo.
  4. Execute bundle exec fastlane run swiftlint progress:true to see how it works.

@ObjectiveCesar

Copy link
Copy Markdown
Contributor Author

I'm not quite sure why most of the CircleCI tasks fail due to permission issues. Maybe somebody can advise me what to do here?

@ObjectiveCesar

Copy link
Copy Markdown
Contributor Author

I'm not quite sure why most of the CircleCI tasks fail due to permission issues. Maybe somebody can advise me what to do here?

I guess, I needed to use the original Gemfile.lock.

@ObjectiveCesar

Copy link
Copy Markdown
Contributor Author

Why is this PR lying around for over a year? It is not a major change. @joshdholtz

@ObjectiveCesar

ObjectiveCesar commented May 28, 2025

Copy link
Copy Markdown
Contributor Author

Bump!

@aleufms

aleufms commented Apr 9, 2026

Copy link
Copy Markdown

can you merge this? @joshdholtz

@iBotPeaches

Copy link
Copy Markdown
Member

This PR was quite old. I merged master into it, to trigger CI so we can see if this is mergable or not.

@iBotPeaches iBotPeaches merged commit c32cb71 into fastlane:master Apr 14, 2026
9 checks passed

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ObjectiveCesar 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a month, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀"

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.233.0 🚀

@github-actions github-actions Bot locked and limited conversation to collaborators Jun 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants