[match] Have Match download Apple's Developer ID intermediate certificates#21364
[match] Have Match download Apple's Developer ID intermediate certificates#21364iOSGeekster wants to merge 2 commits into
Conversation
iOSGeekster
changed the title
|
Is it someway possible to restart the checks, without authorising CircleCI? I think that failing tests are just a bit flaky. |
|
@iOSGeekster Thanks a lot for having submitted this PR ❤️ . I know it's been submitted a long time ago, so sorry for not getting to it sooner 😓 We've opened #29890 to rebase the changes you did in this PR on top of the latest commits and have merged the changes from that PR since, hence yours being auto-closed now that the same changes have been applied by the other one. |
|
The pull request #29890 that closed this issue was merged and released as part of fastlane 2.232.0 🚀 |
No worries. Havn't pushed much against this getting looked at. Glad to see that the changes were usable. |
4 participants
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
When using
matchto sign a Mac app, that is to be published via a notarizeddmgfile, aDeveloper IDcertificate is used to sign the app.And just like when signing apps for the AppStore, with distribution certificates, a Apple WWDR certificate is needed in the keychain to validate the certificate chain.
So Apple's two developer ID intermediate certificates, from Apples Certificate Authority Page has been added to the existing list of WWDR certificates
Description
cert_checker.rb