feat: allow workflow to be more flexible/customizable#10
Closed
darkgl0w wants to merge 3 commits intofastify:mainfrom
Closed
feat: allow workflow to be more flexible/customizable#10darkgl0w wants to merge 3 commits intofastify:mainfrom
darkgl0w wants to merge 3 commits intofastify:mainfrom
Conversation
4 tasks
Member
|
Not too sure about this one to be honest, @darkgl0w. The idea of these shared workflows was to try and enforce a standardised workflow (and in turn script naming conventions, and node versions supported) used across the org plugin repos. It also meant we would only need to update a single repo for workflow changes rather than having to update 80+ separately. If they all decide to use different node versions via customisation options when we drop a node version I'd still have to update them all separately, and they may as well continue to have their own workflows in that case. |
Member
Author
|
@Fdawgs > Indeed, from this point of view this PR does not make sense. 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
Following the discussion in #9, this PR aims to :
linterand thetestjobsChecklist
and the Code of conduct