Skip to content

Benchmark workflow #89

@Uzlopak

Description

@Uzlopak

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

We should have a nice benchmark workflow for use in different repos.

While writing the benchmark workflow of fsj, i saw some issues, which should be tackled:

  • the pr comment action is using node 12 and results in warnings. I am pretty sure we can use octokit/request-action instead
  • we should use the new way to handle outputs, see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ . I tried to use it, but there a formatting issues which dont work with the new way of outputting information.
  • we should think of a way to handle a matrix strategy for the node version. Input variables can not be array. So we should check if you are just pass a comma separated list, where we slab brackets around and the use the json parse method of the github runner. This we could use for the other workflows here in this repo too. But for fsj, i dont need benchmarks from node14 to node 20. I just need one, and thats the lts.
  • we need to investigate a nice way to create the pull request body.
  • we should use the default_branch information from the event instead of hardcoding 'master' or 'main'. Maybe use an input variable, where default is the default_branch?

Motivation

No response

Example

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions