Conversation
mcollina
approved these changes
Jan 20, 2018
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
LGTM. Is this affecting benchmarks at all?
Member
Author
|
@mcollina I didn't check, but since we are adding just an |
mcollina
reviewed
Jan 20, 2018
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
This should be documented somewhere. Also, what would happen if next() is called twice or after release().
Member
Author
If you call twice
Document what? |
Member
|
ok ;). Let’s ship this.. semver-minor?
Il giorno sab 20 gen 2018 alle 17:45 Tomas Della Vedova <
[email protected]> ha scritto:
… Also, what would happen if next() is called twice or after release().
If you call twice next() you will get Cannot read property 'originalUrl'
of null.
This should be documented somewhere.
Document what?
If a previous middleware calls res.end the next one will never run?
Shouldn't this be implicit? 🤔
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADL4-snUrUcPIHWpwFw63rE6RxafBw_ks5tMhgSgaJpZM4RlfUa>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled.