Dependabot/output doesnot seem to appear#539#574
Merged
simoneb merged 7 commits intofastify:merge-status-outputfrom Feb 8, 2024
PhanindraNeralla:dependabot/output-doesnot-seem-to-appear#539
Merged
Dependabot/output doesnot seem to appear#539#574simoneb merged 7 commits intofastify:merge-status-outputfrom PhanindraNeralla:dependabot/output-doesnot-seem-to-appear#539
simoneb merged 7 commits intofastify:merge-status-outputfrom
PhanindraNeralla:dependabot/output-doesnot-seem-to-appear#539
Conversation
simoneb
reviewed
Feb 8, 2024
|
|
||
| if (USE_GITHUB_AUTO_MERGE) { | ||
| await client.enableAutoMergePullRequest(pr.node_id, MERGE_METHOD) | ||
| core.setOutput(MERGE_STATUS_KEY, MERGE_STATUS.merged) |
Collaborator
There was a problem hiding this comment.
I'm not sure this status is right. Automerge means that GitHub may eventually auto merge this, but not that this has already been merged. Maybe we need a new status?
Contributor
Author
There was a problem hiding this comment.
Added new merge_status: "auto_merge".
simoneb
approved these changes
Feb 8, 2024
simoneb
added a commit
that referenced
this pull request
Feb 9, 2024
* fix: merge status output not working * Dependabot/output doesnot seem to appear#539 (#574) * Fixes dependabot/output-doesnot-seem-to-appear#539 * #539 adding random merge status key to verify * #539 adding random merge status keys * #539 removed log messages. Added workflow id to workflow * #539 added workflow id to action yaml * #539 removed unneeded changes in action yaml file * fix #539 added new merge status for auto merge * #539 added testcase for auto merge (#576) * chore: rename main to approver in workflow --------- Co-authored-by: Phanindra Neralla <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Add Merge status in Auto-merge scenario
Checklist
npm run testandnpm run benchmarkand the Code of conduct