chore (ci): migrate ci to fastify plugins reusable workflows#531
Merged
Eomm merged 5 commits intofastify:masterfrom Jan 27, 2022
Merged
chore (ci): migrate ci to fastify plugins reusable workflows#531Eomm merged 5 commits intofastify:masterfrom
Eomm merged 5 commits intofastify:masterfrom
Conversation
Pull Request Test Coverage Report for Build 1736512411
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1736512411Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Eomm
requested changes
Jan 23, 2022
Member
Eomm
left a comment
Eomm
left a comment
There was a problem hiding this comment.
Could we migrate this repo to the new centalized worfflow?
It would be cool to:
- add the "1 lint runs" on the main flow https://github.com/fastify/workflows/
- reference the flow here (example: fastify/fastify-autoload#216 )
Member
Author
|
@Eomm > sure I will take a look to do so. I will create a linter "standalone" workflow so that we should be able to use it like this : name: ci
on:
push:
paths-ignore:
- 'docs/**'
- '*.md'
pull_request:
paths-ignore:
- 'docs/**'
- '*.md'
jobs:
linter:
uses: fastify/workflows/.github/workflows/linter-ci.yml@v2
test:
needs: linter
uses: fastify/workflows/.github/workflows/plugins-ci.yml@v2 |
2 tasks
Member
Author
|
On hold. |
darkgl0w
changed the title
Eomm
approved these changes
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
This PR aims to :
tap(enforcing 100% code coverage)Checklist
npm run testandnpm run benchmarkand the Code of conduct