Merged
Conversation
2 tasks
mcollina
requested changes
Feb 28, 2025
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.
Contributor
Author
|
Hi @mcollina I really am not sure how to write a test for this (maybe I am being dumb (feeling tired today))... Any guidance? How do you watch that the already-sent-error is not triggered? |
Member
|
I'll take a look but @climba03003 if you have some time, I'd appreciate a review :) |
Member
|
I think that the already sent error is showed in logs, so you can install a "fake" log stream, collect all lines, then analize them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #497
Checklist
npm run testandnpm run benchmarkand the Code of conduct